Skip to content

feat: Feature adding top level management group name #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaredfholgate merged 3 commits into from
Dec 19, 2024
Merged

feat: Feature adding top level management group name #61

jaredfholgate merged 3 commits into from
Dec 19, 2024

Conversation

@sdeguchi
Copy link
Contributor

@sdeguchi sdeguchi commented Dec 16, 2024 •
edited
Loading

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Feature Request: Move bootstrap modules into bootstrap and support configurable top level management group name Azure-Landing-Zones#2451

Breaking Changes

None

Testing Evidence

image

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@sdeguchi sdeguchi requested a review from a team December 16, 2024 23:17
@sdeguchi sdeguchi changed the title Feature adding top level management group name feat: Feature adding top level management group name Dec 16, 2024
jaredfholgate
jaredfholgate approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jaredfholgate jaredfholgate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Dec 19, 2024
@jaredfholgate jaredfholgate mentioned this pull request Dec 19, 2024
Closed
@jaredfholgate jaredfholgate merged commit 8ddc147 into main Dec 19, 2024
33 checks passed
@jaredfholgate jaredfholgate deleted the feature-adding-top-level-management-group-name branch December 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaredfholgate jaredfholgate jaredfholgate approved these changes

Assignees

No one assigned

Labels

PR: Safe to test 🧪 Enables running of End to End Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sdeguchi @jaredfholgate