Skip to content

Bug: Only public networking is allowed with Microsoft-Hosted agents / runners #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jaredfholgate merged 2 commits into from
Sep 4, 2024
Merged

Bug: Only public networking is allowed with Microsoft-Hosted agents / runners #32

jaredfholgate merged 2 commits into from
Sep 4, 2024

Conversation

@jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Sep 4, 2024 •
edited
Loading

Overview/Summary

Replace this with a brief description of what this Pull Request fixes, changes, etc.

This PR fixes/adds/changes/removes

  1. Bug: Terraform Init Fails Due to Azure Storage Account Network Configuration in Landing Zone Deployment Azure-Landing-Zones#2504

Breaking Changes

None, the existing combination was not valid anyway

Testing Evidence

e2e tests

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Sep 4, 2024
@jaredfholgate jaredfholgate added the PR: Safe to test 🧪 Enables running of End to End Tests label Sep 4, 2024
@jaredfholgate jaredfholgate changed the title Only public networking is allowed with Microsoft-Hosted agents / runners Bug: Only public networking is allowed with Microsoft-Hosted agents / runners Sep 4, 2024
@jaredfholgate jaredfholgate merged commit 019d1ed into main Sep 4, 2024
@jaredfholgate jaredfholgate deleted the bug-only-allow-public-networking-for-microsoft-agents-and-runners branch September 4, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matt-FFFFFF matt-FFFFFF matt-FFFFFF approved these changes

@jtracey93 jtracey93 Awaiting requested review from jtracey93

Assignees

@jaredfholgate jaredfholgate

Labels

PR: Safe to test 🧪 Enables running of End to End Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jaredfholgate @matt-FFFFFF