-
Notifications
You must be signed in to change notification settings - Fork 27
Implement Azure Container Registry for Container images #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@jaredfholgate Is it worth wrapping private dns zones/private endpoints into a for_each now if we have multiple instances? |
Good suggestion, have made that change. I appreciate the code could be neater in general. My intention is to do more refactoring when time allows and move as much as possible to AVM too. |
|
Sorry slipped though. LGTM! |
Overview/Summary
This PR replaces the docker hub based image with a local ACR that builds the image on demand.
This was a long planned addition, but has been expedited by throttling that has been applied to Docker Hub.
We were considering a move to MAR / MCR, but this is too challenging.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
e2e tests have been run that cover all the relevant use cases for this change.
As part of this Pull Request I have
mainbranch