Skip to content

Conversation

@jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Jul 4, 2024

Overview/Summary

This PR replaces the docker hub based image with a local ACR that builds the image on demand.

This was a long planned addition, but has been expedited by throttling that has been applied to Docker Hub.

We were considering a move to MAR / MCR, but this is too challenging.

This PR fixes/adds/changes/removes

  1. Feature Request: Migrate container images Azure-Landing-Zones#2529

Breaking Changes

  1. Containers are now hosted in ACR

Testing Evidence

e2e tests have been run that cover all the relevant use cases for this change.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Jul 4, 2024
@jaredfholgate jaredfholgate added the Type: Enhancement ✨ New feature or request label Jul 4, 2024
@jaredfholgate jaredfholgate marked this pull request as ready for review July 4, 2024 17:48
@luke-taylor
Copy link

@jaredfholgate Is it worth wrapping private dns zones/private endpoints into a for_each now if we have multiple instances?

@jaredfholgate
Copy link
Member Author

@jaredfholgate Is it worth wrapping private dns zones/private endpoints into a for_each now if we have multiple instances?

Good suggestion, have made that change. I appreciate the code could be neater in general. My intention is to do more refactoring when time allows and move as much as possible to AVM too.

@jaredfholgate jaredfholgate merged commit 0ee80b3 into main Jul 5, 2024
@jaredfholgate jaredfholgate deleted the implement-acr branch July 5, 2024 09:35
@matt-FFFFFF
Copy link
Member

Sorry slipped though. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Safe to test 🧪 Enables running of End to End Tests Type: Enhancement ✨ New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants