Skip to content

fix: uninitialized $os variable causing incorrect PATH separator on Windows #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaredfholgate merged 3 commits into from
Dec 17, 2025
Merged

fix: uninitialized $os variable causing incorrect PATH separator on Windows #123

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a2aadc
Initial plan
Copilot Dec 17, 2025
400e415
Fix terraform.exe location bug by moving OS detection before first us…
Copilot Dec 17, 2025
fbf5885
Merge branch 'main' into copilot/fix-terraform-exe-location-bug
jaredfholgate Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 49 additions & 55 deletions alz/azuredevops/pipelines/terraform/templates/helpers/terraform-installer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,6 @@ steps:
}
}

$unzipdir = Join-Path -Path $TOOLS_PATH -ChildPath "terraform_$TF_VERSION"
if (Test-Path $unzipdir) {
Write-Host "Terraform $TF_VERSION already installed."
if($os -eq "windows") {
$env:PATH = "$($unzipdir);$env:PATH"
} else {
$env:PATH = "$($unzipdir):$env:PATH"
}
Write-Host "##vso[task.setvariable variable=PATH]$env:PATH"
return
}

$os = ""
if ($IsWindows) {
$os = "windows"
Expand All @@ -60,58 +48,66 @@ steps:
$os = "darwin"
}

# Enum values can be seen here: https://learn.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.architecture?view=net-7.0#fields
$architecture = ([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture).ToString().ToLower()
$unzipdir = Join-Path -Path $TOOLS_PATH -ChildPath "terraform_$TF_VERSION"
if (Test-Path $unzipdir) {
Write-Host "Terraform $TF_VERSION already installed."
} else {
# Enum values can be seen here: https://learn.microsoft.com/en-us/dotnet/api/system.runtime.interopservices.architecture?view=net-7.0#fields
$architecture = ([System.Runtime.InteropServices.RuntimeInformation]::OSArchitecture).ToString().ToLower()

if($architecture -eq "x64") {
$architecture = "amd64"
}
if($architecture -eq "x86") {
$architecture = "386"
}
if($architecture -eq "x64") {
$architecture = "amd64"
}
if($architecture -eq "x86") {
$architecture = "386"
}

$osAndArchitecture = "$($os)_$($architecture)"

$supportedOsAndArchitectures = @(
"darwin_amd64",
"darwin_arm64",
"linux_386",
"linux_amd64",
"linux_arm64",
"windows_386",
"windows_amd64"
)

if($supportedOsAndArchitectures -notcontains $osAndArchitecture) {
Write-Error "Unsupported OS and architecture combination: $osAndArchitecture"
exit 1
}
$osAndArchitecture = "$($os)_$($architecture)"

$supportedOsAndArchitectures = @(
"darwin_amd64",
"darwin_arm64",
"linux_386",
"linux_amd64",
"linux_arm64",
"windows_386",
"windows_amd64"
)

if($supportedOsAndArchitectures -notcontains $osAndArchitecture) {
Write-Error "Unsupported OS and architecture combination: $osAndArchitecture"
exit 1
}

$zipfilePath = "$unzipdir.zip"
$zipfilePath = "$unzipdir.zip"

$url = $release.builds | Where-Object { $_.arch -eq $architecture -and $_.os -eq $os } | Select-Object -First 1 -ExpandProperty url
$url = $release.builds | Where-Object { $_.arch -eq $architecture -and $_.os -eq $os } | Select-Object -First 1 -ExpandProperty url

if(!(Test-Path $TOOLS_PATH)) {
New-Item -ItemType Directory -Path $TOOLS_PATH| Out-String | Write-Verbose
}
if(!(Test-Path $TOOLS_PATH)) {
New-Item -ItemType Directory -Path $TOOLS_PATH| Out-String | Write-Verbose
}

Invoke-WebRequest -Uri $url -OutFile "$zipfilePath" | Out-String | Write-Verbose
Invoke-WebRequest -Uri $url -OutFile "$zipfilePath" | Out-String | Write-Verbose

Expand-Archive -Path $zipfilePath -DestinationPath $unzipdir
Expand-Archive -Path $zipfilePath -DestinationPath $unzipdir

$toolFileName = "terraform"
$toolFileName = "terraform"

if($os -eq "windows") {
$toolFileName = "$($toolFileName).exe"
}
if($os -eq "windows") {
$toolFileName = "$($toolFileName).exe"
}

$toolFilePath = Join-Path -Path $unzipdir -ChildPath $toolFileName
$toolFilePath = Join-Path -Path $unzipdir -ChildPath $toolFileName

if($os -ne "windows") {
$isExecutable = $(test -x $toolFilePath; 0 -eq $LASTEXITCODE)
if(!($isExecutable)) {
chmod +x $toolFilePath
}
if($os -ne "windows") {
$isExecutable = $(test -x $toolFilePath; 0 -eq $LASTEXITCODE)
if(!($isExecutable)) {
chmod +x $toolFilePath
}
}

Remove-Item $zipfilePath
Write-Host "Installed Terraform version $TF_VERSION"
}

if($os -eq "windows") {
Expand All @@ -120,8 +116,6 @@ steps:
$env:PATH = "$($unzipdir):$env:PATH"
}
Write-Host "##vso[task.setvariable variable=PATH]$env:PATH"
Remove-Item $zipfilePath
Write-Host "Installed Terraform version $TF_VERSION"

displayName: Install Terraform
env:
Expand Down
Loading