-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Included Workload Profile, UDR and Azure Firewall into Terraform implementation #132
Included Workload Profile, UDR and Azure Firewall into Terraform implementation #132
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here! Thanks for the contribution. Had a few comments around making sure properties are controlled by variables, workload profile is still optional and ensuring the new modules are consistent with the existing Bicep implementation. Once you've made those updates, I'll do a test deployment, verify everything looks good and approve. Thanks!
scenarios/aca-internal/terraform/modules/05-hello-world-sample-app/main.tf
Outdated
Show resolved
Hide resolved
scenarios/shared/terraform/modules/networking/route-table/variables.tf
Outdated
Show resolved
Hide resolved
scenarios/shared/terraform/modules/networking/route-table/main.tf
Outdated
Show resolved
Hide resolved
@ibersanoMS done :) You can re-check ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can just fix the IP, I'll approve and we can get this merged! Thanks!
…m/HoussemDellai/aca-landing-zone-accelerator into terraform-workload-profile-udr-fw
@ibersanoMS done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look Great! Thanks!
Changes in this PR:
Tested and working:
curl ifconf.me
)Tested and not working: