MAINT: Separating integration test local .env #817
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| AZURE_SQL_DB_CONNECTION_STRING = ${AZURE_SQL_DB_CONNECTION_STRING_TEST} | ||
| AZURE_STORAGE_ACCOUNT_DB_DATA_CONTAINER_URL=${AZURE_STORAGE_ACCOUNT_DB_DATA_CONTAINER_URL_TEST} | ||
|
|
||
| GLOBAL_MEMORY_LABELS = {"username": "integration-test"} |
There was a problem hiding this comment.
maybe op_name is a better key name. I expect the username to be different for whoever running the integ tests
jsong468
reviewed
Mar 24, 2025
| @@ -0,0 +1,29 @@ | |||
| ############### | |||
| # This is .env.local file is used for integration tests | |||
There was a problem hiding this comment.
NIT
Suggested change
| # This is .env.local file is used for integration tests | |
| # This .env.local file is used for integration tests |
romanlutz
reviewed
Mar 24, 2025
| OPENAI_CHAT_KEY=${AZURE_OPENAI_INTEGRATION_TEST_KEY} | ||
| OPENAI_CHAT_MODEL="gpt-4o" | ||
|
|
||
| OPENAI_DALLE_ENDPOINT = ${OPENAI_DALLE_ENDPOINT2} |
There was a problem hiding this comment.
Suggested change
| OPENAI_DALLE_ENDPOINT = ${OPENAI_DALLE_ENDPOINT2} | |
| OPENAI_DALLE_ENDPOINT = ${OPENAI_DALLE_ENDPOINT2} |
| AZURE_SQL_DB_CONNECTION_STRING = ${AZURE_SQL_DB_CONNECTION_STRING_TEST} | ||
| AZURE_STORAGE_ACCOUNT_DB_DATA_CONTAINER_URL=${AZURE_STORAGE_ACCOUNT_DB_DATA_CONTAINER_URL_TEST} | ||
|
|
||
| GLOBAL_MEMORY_LABELS = {"username": "integration-test"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I just used our .env_example file, but I created a new file here to separate out how we configure integration tests.