Skip to content

Conversation

@BenjaminEngeset
Copy link
Contributor

PR Summary

Fixes #3553

feat: Updated Azure.AppGwWAF.RuleGroups to use Microsoft Default Rule Set.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • Change is not breaking
  • This PR is ready to merge and is not Work in Progress
  • Rule changes
    • Unit tests created/ updated
    • Rule documentation created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section
  • Other code changes
    • Unit tests created/ updated
    • Link to a filed issue
    • Change log has been updated with change under unreleased section

@BenjaminEngeset BenjaminEngeset requested a review from a team as a code owner October 28, 2025 14:12
@BenjaminEngeset
Copy link
Contributor Author

Hi @BernieWhite, it’s been a while! I hope you’re doing well. Let me know what you think about this one.

Copy link
Collaborator

@BernieWhite BernieWhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @BenjaminEngeset. Looks good. I added a few additional updates to docs and rule to align this rule to new rules as this one was a little out of date.

Please review my changes and if you have any questions let me know.

If there is no issues with my updates I'll get it merged. Thanks.

@BenjaminEngeset
Copy link
Contributor Author

It looks great now @BernieWhite. Lets merge.

@BernieWhite BernieWhite merged commit 9e617d9 into Azure:main Nov 1, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RULE] Add option Microsoft_DefaultRuleSet 2.1 in Azure.AppGwWAF.RuleGroups

2 participants