Skip to content

Fix GitHub Actions workflow and Azure Pipelines issues from review feedback#6

Merged
mkrueger merged 2 commits into
dev/mkrueger/workflowsfrom
copilot/sub-pr-4-again
Mar 20, 2026
Merged

Fix GitHub Actions workflow and Azure Pipelines issues from review feedback#6
mkrueger merged 2 commits into
dev/mkrueger/workflowsfrom
copilot/sub-pr-4-again

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 20, 2026

Several correctness and safety issues in the GitHub Actions and Azure Pipelines workflows identified during review: fuzzer CI could silently pass with crash findings, dotnet pack payload versioning was inconsistent with the package version, and NuGet push steps in ADO lacked branch/parameter gates allowing unintended publishes from any branch.

Changes

.github/workflows/ci.yml

  • Added --no-restore to fuzzer dotnet run to prevent a second restore against the wrong NuGet config
  • Added a post-fuzzer step that scans for crash_*.txt findings and fails CI if any exist

.github/workflows/package-unsigned.yml

  • dotnet pack now passes Version, FileVersion, and InformationalVersion alongside PackageVersion so the tool binary metadata inside the nupkg is consistent with the declared package version

.pipelines/CosmosDB-Shell-Official.yml

  • Restored publishNuget queue-time boolean parameter and re-added Build.SourceBranch == refs/heads/main && publishNuget == true guard on both NuGet push steps
  • Fixed version normalization: $buildNumber is now updated after normalization so CosmosDBShell_InformationalVersion is derived from the canonical version rather than the pre-normalization value

CONTRIBUTING.md

  • Corrected wording: "produces unsigned package artifacts" → "uploads unsigned artifacts" (the workflow uploads to GitHub Actions artifacts, not a feed)

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

…oning, ADO branch gate, info version fix

Co-authored-by: mkrueger <341098+mkrueger@users.noreply.github.com>
Copilot AI changed the title [WIP] Add GitHub workflows for building Fix GitHub Actions workflow and Azure Pipelines issues from review feedback Mar 20, 2026
Copilot AI requested a review from mkrueger March 20, 2026 12:01
@mkrueger mkrueger marked this pull request as ready for review March 20, 2026 12:05
@mkrueger mkrueger merged commit 5789495 into dev/mkrueger/workflows Mar 20, 2026
2 checks passed
@mkrueger mkrueger deleted the copilot/sub-pr-4-again branch March 20, 2026 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants