Skip to content

Fix CI fuzzer restore isolation, pack versioning consistency, and NuGet push branch gating #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix CI fuzzer restore isolation, pack versioning consistency, and NuGet push branch gating #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67e0cd4
Initial plan
Copilot Mar 20, 2026
0744c9f
Apply review feedback: fix versioning, no-restore flag, and NuGet pus…
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:

- name: Run fuzzer smoke test
working-directory: CosmosDBShell.Fuzzer
run: dotnet run --configuration $env:BUILD_CONFIGURATION --no-build -- --all
run: dotnet run --configuration $env:BUILD_CONFIGURATION --no-build --no-restore -- --all
shell: pwsh

- name: Upload test results
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/package-unsigned.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,11 @@ jobs:
New-Item -ItemType Directory -Path out/nupkg -Force | Out-Null
dotnet pack CosmosDBShell/CosmosDBShell.csproj `
--configuration $env:BUILD_CONFIGURATION `
--no-build `
--no-restore `
--output out/nupkg `
/p:Version=${{ steps.version.outputs.package_version }} `
/p:FileVersion=${{ steps.version.outputs.file_version }} `
/p:InformationalVersion=${{ steps.version.outputs.informational_version }} `
/p:PackageVersion=${{ steps.version.outputs.package_version }} `
/p:ContinuousIntegrationBuild=true

Expand Down
5 changes: 3 additions & 2 deletions .pipelines/CosmosDB-Shell-Official.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ extends:
if ($buildNumber -ne $version) {
Write-Host "Updating Build.BuildNumber to normalized NuGet version: $version"
Write-Host "##vso[build.updatebuildnumber]$version"
$buildNumber = $version
}

$fileVersion = $version
Expand Down Expand Up @@ -494,7 +495,7 @@ extends:

- task: NuGetCommand@2
displayName: "Push RID-specific NuGet packages"
condition: succeeded()
condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/main'))
inputs:
command: "push"
packagesToPush: |
Expand All @@ -508,7 +509,7 @@ extends:
allowPackageConflicts: true
- task: NuGetCommand@2
displayName: "Push pointer NuGet package"
condition: succeeded()
condition: and(succeeded(), eq(variables['Build.SourceBranch'], 'refs/heads/main'))
inputs:
command: "push"
packagesToPush: "$(Build.SourcesDirectory)\\out\\nupkg\\CosmosDBShell.$(CosmosDBShell_Version).nupkg"
Expand Down