delete ingress folder and add ingress yaml (WIP) #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubramanianaks
requested review from
Tatsinnit,
sabbour and
a team
as code owners
Tatsinnit
previously approved these changes
Feb 20, 2024
hsubramanianaks
dismissed stale reviews from Tatsinnit and Vidya2606
via
418043a
hsubramanianaks
changed the title
Vidya2606
previously approved these changes
Feb 20, 2024
hsubramanianaks
changed the title
hsubramanianaks
commented
Feb 22, 2024
hsubramanianaks
commented
Feb 22, 2024
Vidya2606
approved these changes
Feb 22, 2024
Tatsinnit
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up ingress folder (it is duplication of samples/todo-app but with ingress) and replaced it with deployment-ingress.yaml which creates an ingress. Also removed deployment-arm yaml's which aren't required since docker builds are using buildx which builds for multiple platforms.
while testing this PR found out, several dependencies were updated causing some changes to samples folder ex: anchor is deprecated in next.js.