Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix recommendation YAML style #656

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: Fix recommendation YAML style #656

merged 1 commit into from
Feb 19, 2025
+4 −3

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Feb 12, 2025

Overview/Summary

Fix a recommendation YAML style for consistency.

  • Added an empty line between recommendations.
  • Removed verbose white-spaces.
  • Fixed the product name.
  • Removed the language specified part from the URL.

Related Issues/Work Items

Breaking Changes

  • None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings February 12, 2025 15:14
@tksh164 tksh164 requested a review from a team as a code owner February 12, 2025 15:14
Copilot
Copilot AI reviewed Feb 12, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Feb 12, 2025
oZakari
oZakari approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ejhenry
ejhenry approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 979d660 into main Feb 19, 2025
9 checks passed
@tksh164 tksh164 deleted the fix/recomm-yaml-format branch February 19, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@oZakari oZakari oZakari approved these changes

@ejhenry ejhenry ejhenry approved these changes

Assignees
No one assigned
Labels
Auto-Merge ✔️ Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tksh164 @oZakari @ejhenry