Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Schema updates for tags and values #634

Merged
merged 9 commits into from
Jan 28, 2025

Conversation

oZakari
Copy link
Collaborator

@oZakari oZakari commented Jan 24, 2025

Overview/Summary

Transitions schema for tags to support lists of values as well as to switch supported value of AI to AI-GPT-RAG.

Related Issues/Work Items

Related to ADO Item

Breaking Changes

None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings January 24, 2025 22:36
@oZakari oZakari requested review from a team as code owners January 24, 2025 22:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

Files not reviewed (1)
  • docs/archetypes/azure-resource-type/recommendations.yaml: Language not supported
Comments suppressed due to low confidence (1)

docs/content/contributing/create-content/create-recommendations/_index.md:80

  • [nitpick] The example value for 'tags' should include all possible values like '[AI-GTP-RAG, AVD, AVS, HPC, SAP]' instead of just '[AVD]'.
| tags | [AVD]| String | [AI-GTP-RAG, AVD, AVS, HPC, SAP] | Indicates which type of specialized workload the recommendation is associated to.

@oZakari oZakari requested review from a team as code owners January 24, 2025 22:51
@oZakari oZakari force-pushed the schema-tag-updates branch from d1d041d to 25af711 Compare January 24, 2025 22:54
@oZakari oZakari changed the title refactor: Schema updates for AI refactor: Schema updates for tags and values Jan 24, 2025
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ejhenry ejhenry merged commit c097454 into Azure:main Jan 28, 2025
8 checks passed
@tksh164 tksh164 mentioned this pull request Jan 29, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants