-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Schema updates for tags and values #634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.
Files not reviewed (1)
- docs/archetypes/azure-resource-type/recommendations.yaml: Language not supported
Comments suppressed due to low confidence (1)
docs/content/contributing/create-content/create-recommendations/_index.md:80
- [nitpick] The example value for 'tags' should include all possible values like '[AI-GTP-RAG, AVD, AVS, HPC, SAP]' instead of just '[AVD]'.
| tags | [AVD]| String | [AI-GTP-RAG, AVD, AVS, HPC, SAP] | Indicates which type of specialized workload the recommendation is associated to.
docs/archetypes/azure-specialized-workload/recommendations.yaml
Outdated
Show resolved
Hide resolved
docs/archetypes/azure-specialized-workload/recommendations.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
…iency-Library-v2 into schema-tag-updates
d1d041d
to
25af711
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview/Summary
Transitions schema for tags to support lists of values as well as to switch supported value of AI to AI-GPT-RAG.
Related Issues/Work Items
Related to ADO Item
Breaking Changes
None
As part of this pull request I have
main
branch