Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix on filtering resourcetypes on ImpactedResources #632

Merged
merged 2 commits into from
Jan 24, 2025
Merged

fix: fix on filtering resourcetypes on ImpactedResources #632

merged 2 commits into from
Jan 24, 2025

Conversation

Claudio-Merola
Copy link
Contributor

Overview/Summary

Fix resource types not present in APRL being left out from ImpactedResources sheet

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings January 23, 2025 18:58
@Claudio-Merola Claudio-Merola requested a review from a team as a code owner January 23, 2025 18:58
Copilot
Copilot AI reviewed Jan 23, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (2)
  • tools/2_wara_data_analyzer.ps1: Language not supported
  • tools/Version.json: Language not supported
@microsoft-github-policy-service microsoft-github-policy-service bot added the Bug 🐞 Something isn't working label Jan 23, 2025
@rodrigosantosms rodrigosantosms merged commit 6b2c4db into Azure:main Jan 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@rodrigosantosms rodrigosantosms rodrigosantosms approved these changes

@ejhenry ejhenry ejhenry approved these changes

Assignees
No one assigned
Labels
Bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Claudio-Merola @rodrigosantosms @ejhenry