Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Limit learnmorelink to one link per recommendation #618

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

oZakari
Copy link
Collaborator

@oZakari oZakari commented Jan 15, 2025

Overview/Summary

In order to align to Azure Advisor schema, we need to reduce the number of allowed links per recommendation to 1.

I have used AI to select the most relevant links to keep.

Related Issues/Work Items

Fixes AB#38474

Breaking Changes

  1. None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings January 15, 2025 22:56
@oZakari oZakari requested review from a team as code owners January 15, 2025 22:56

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 27 out of 42 changed files in this pull request and generated no comments.

Files not reviewed (15)
  • azure-resources/Compute/virtualMachines/recommendations.yaml: Evaluated as low risk
  • azure-resources/Databricks/workspaces/recommendations.yaml: Evaluated as low risk
  • azure-resources/Dashboard/grafana/recommendations.yaml: Evaluated as low risk
  • azure-resources/ContainerService/managedClusters/recommendations.yaml: Evaluated as low risk
  • azure-resources/ContainerRegistry/registries/recommendations.yaml: Evaluated as low risk
  • azure-resources/DocumentDB/databaseAccounts/recommendations.yaml: Evaluated as low risk
  • azure-resources/Devices/iotHubs/recommendations.yaml: Evaluated as low risk
  • azure-resources/Compute/virtualMachineScaleSets/recommendations.yaml: Evaluated as low risk
  • azure-resources/Compute/galleries/recommendations.yaml: Evaluated as low risk
  • azure-resources/AVS/privateClouds/recommendations.yaml: Evaluated as low risk
  • azure-resources/MachineLearningServices/workspaces/recommendations.yaml: Evaluated as low risk
  • azure-resources/NetApp/netAppAccounts/recommendations.yaml: Evaluated as low risk
  • azure-resources/Network/applicationGateways/recommendations.yaml: Evaluated as low risk
  • azure-resources/Compute/disks/recommendations.yaml: Evaluated as low risk
  • azure-resources/Cdn/profiles/recommendations.yaml: Evaluated as low risk
@oZakari oZakari changed the title Limit learnmorelink to one link per recommendation refactor: Limit learnmorelink to one link per recommendation Jan 15, 2025
@oZakari oZakari added the Enhancement 🆕 New feature or request label Jan 15, 2025
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oZakari! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement 🆕 New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants