Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: aisearch resiliency recommendations #603

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

ripadrao
Copy link

@ripadrao ripadrao commented Jan 7, 2025

Overview/Summary

AI Search resiliency: Enable AZ support in AI Search by configuring multiple replicas to your search service
AI Search Resiliency: Enable Multi Region deployments for AI Search

Related Issues/Work Items

https://dev.azure.com/CSUSolEng/Accelerator%20-%20AI/_workitems/edit/38367
https://dev.azure.com/CSUSolEng/Accelerator%20-%20AI/_workitems/edit/38366

image image image image image image
  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@Copilot Copilot bot review requested due to automatic review settings January 7, 2025 10:32
@ripadrao ripadrao requested a review from a team as a code owner January 7, 2025 10:32

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

azure-resources/CognitiveServices/AIsearch/recommendations.yaml:11

  • The word 'potentialBenefits' is incorrectly placed within the description text and should be removed.
longDescription: | Availability zones are used when adding multiple replicas to your search service. Each replica is assigned to a different zone in the region. If there are more replicas than zones, they are distributed as evenly as possible across the available zones.  potentialBenefits: High Availability

azure-resources/CognitiveServices/AIsearch/kql/b376281d-bfec-4695-8f90-9a44544fdfa4.kql:7

  • The use of strcat is redundant when concatenating a single property. It should be replaced with the property itself.
| project recommendationId = "b376281d-bfec-4695-8f90-9a44544fdfa4", name, id, param1 = strcat(properties['replicaCount']) , param2 = strcat(location)
@oZakari oZakari requested a review from a team January 14, 2025 20:37
@faister
Copy link

faister commented Jan 15, 2025

@ejhenry please review, this PR is just pending one final review. thanks

- name: Reliability in Azure AI Search
url: "https://learn.microsoft.com/en-us/azure/search/search-reliability#multiple-services-in-separate-geographic-regions"

- description: Use Azure Traffic Manager to route search requests via geo-located clients for failover redundancy.
Copy link
Contributor

@ejhenry ejhenry Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recommendation might make more sense in the AI specialized workload section as it seems to be targeting Traffic Manager for a specific AI scenario. As a specialized workload recommendation, the targeted resource can be a subscription. In this current location, the targeted resources for this recommendation could only be Microsoft.Search/searchServices resources.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the recommendation here azure-specialized-workloads/ai/recommendations.yaml

@ejhenry ejhenry added the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Jan 15, 2025
auto-merge was automatically disabled January 15, 2025 10:25

Head branch was pushed to by a user without write access

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Jan 15, 2025
auto-merge was automatically disabled January 15, 2025 10:28

Head branch was pushed to by a user without write access

auto-merge was automatically disabled January 15, 2025 10:30

Head branch was pushed to by a user without write access

auto-merge was automatically disabled January 15, 2025 10:30

Head branch was pushed to by a user without write access

@@ -0,0 +1,2 @@
// Azure Resource Graph Query
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Azure Resource Graph Query

recommendationTypeId: null
recommendationControl: HighAvailability
recommendationImpact: Medium
recommendationResourceType: Microsoft.Search/searchServices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
recommendationResourceType: Microsoft.Search/searchServices
recommendationResourceType: Microsoft.Subscription/subscriptions

@ejhenry ejhenry added Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author and removed Needs: Attention from aprl-maintainers 👋 Needs attention from aprl-admins GitHub team. labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Merge ✔️ Enhancement 🆕 New feature or request Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants