Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New Oracle odaa sections #463

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

basimolimajeed
Copy link
Contributor

Overview/Summary

APRL input for oracle ODAA. Added both as specialized workload and in the resources section

Related Issues/Work Items

N/A

Breaking Changes

N/A

As part of this pull request I have

  • [ x] Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • [ x] Ensured my code/branch is up-to-date with the latest changes in the main branch
  • [ x] Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@basimolimajeed basimolimajeed requested a review from a team as a code owner October 13, 2024 07:40
@basimolimajeed basimolimajeed changed the title Oracle odaa feat: New Oracle odaa sections Oct 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Oct 13, 2024
@oZakari oZakari requested a review from a team as a code owner October 16, 2024 17:25
@oZakari oZakari force-pushed the Oracle-ODAA branch 2 times, most recently from 3df7c25 to 0901d88 Compare October 16, 2024 18:21
Copy link
Contributor

@ehaslett ehaslett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments about architectural guidance vs specific configurations that affect resiliency.

@@ -0,0 +1,201 @@
- description: Implement a regional replication strategy for Oracle to meet your workload requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

recommendationResourceType: Specialized.Workload/oracle
recommendationMetadataState: Active
longDescription:
Regional replication is a key strategy to ensure business continuity and disaster recovery for your Oracle workloads. Implement a regional replication strategy to meet your workload requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation is agreed by relevant teams and as such we would like to keep it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @ehaslett this reads as a generic best practice rather than an actionable reliability recommendation. We also already have WAF recommendations RE:05 that cover the same topic.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Oracle Maximum Availability Architecture for Oracle Database@Azure Gold Architecture shows that ODAA can be configured for either zonal or regional replication. For regional replication the customer would setup an infrastructure/cluster in both regions then either use Data Guard (active/passive) or Golden Gate (active/active) to replicate either across regions or zones.

@ehaslett or @ejhenry please describe why this is viewed as a best practice and not an actionable reliability recommendation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Oracle Maximum Availability Architecture for Oracle Database@Azure Gold Architecture shows that ODAA can be configured for either zonal or regional replication. For regional replication the customer would setup an infrastructure/cluster in both regions then either use Data Guard (active/passive) or Golden Gate (active/active) to replicate either across regions or zones.

@ehaslett or @ejhenry please describe why this is viewed as a best practice and not an actionable reliability recommendation.

I would ask these questions about the recommendation to determine if it is actionable in terms of APRL guidance and remediation:

  • Can an ARG query be formed to uncover Azure resource configuration(s) that does not meet this guidance?
  • Can a Azure resource configuration that does not meet this guidance be remediated through an Azure resource configuration change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrymandin I have to defer to @oZakari and @rodrigosantosms on this

Copy link
Collaborator

@oZakari oZakari Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @terrymandin, it is okay if you add recommendations that cannot be added validated with ARG. If they are valid recommendations that should be checked during a WARA engagement for Oracle, then I think they should be added in.

However, we don't have a field dedicated for remediation, so please just incorporate a link to remediation guidance
in the learnMoreLink field.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehaslett , based on @oZakari feedback indicating that we can include recommendations that cannot be validated with ARG, could you please review the items below and let us know if we we check them in if a remediation link is added?

Copy link
Contributor

@ehaslett ehaslett Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrymandin I would again have to defer to @ejhenry, @rodrigosantosms and @oZakari about whether or not it is appropriate to evaluate an Oracle configuration (i.e. Oracle portal) vs an Azure configuration, and then also provide remediation guidance for something outside of Azure (i.e. Oracle portal).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oZakari could you review this PR. Some of the recommendations were originally rejected as ARG queries could not be written for them. Your feedback indicates that recommendations do not necessarily need ARG queries. In the comment above @ehaslett is deferring to yourself, Eric or Zach as to whether or not they can be included. Would you be willing to re-review them?

If possible, can you also re-open the PR? It was closed by a bot.

url: "https://docs.oracle.com/en/database/oracle/oracle-database/21/haovw/db-azure1.html#GUID-91572193-DF8E-4D7A-AF65-7A803B89E840"


- description: Implement a strategy for resiliency that is tailored to your Oracle workload requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation is agreed by relevant teams and as such we would like to keep it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @ehaslett this reads as a generic best practice rather than an actionable reliability recommendation. We also already have WAF recommendations RE:05 that cover the same topic.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basimolimajeed , due to the APRL requirements @ehaslett mentions above, this should be moved to WAF.

- name: Oracle Database@Azure Evaluations by Oracle MAA
url: "https://docs.oracle.com/en/database/oracle/oracle-database/21/haovw/db-azure1.html#GUID-91572193-DF8E-4D7A-AF65-7A803B89E840"

- description: Implement a backup and restore strategy for Oracle databases to meet your workload requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation is agreed by relevant teams and as such we would like to keep it. Please reach on Teams if you need further discussion with the relevant team experts. thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @ehaslett this reads as a generic best practice rather than an actionable reliability recommendation. We also already have WAF recommendation RE:09 that covers the same topic.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basimolimajeed , due to the APRL requirements @ehaslett mentions above, this should be moved to WAF.

- name: Learn about Oracle Maximum Availability Architecture for Oracle Database@Azure
url: "https://docs.oracle.com/en/solutions/oracle-maa-db-at-azure/#GUID-7723E2B1-9588-40BC-88BE-44637B1AF0D9"

- description: Scale up the VM cluster based on the workload requirement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this might be better stated in terms of monitoring the VM cluster and scaling based on alerting on thresholds set via monitoring.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will discuss with the experts

- name: Learn about Oracle Maximum Availability Architecture for Oracle Database@Azure
url: "https://docs.oracle.com/en/solutions/oracle-maa-db-at-azure/#GUID-7723E2B1-9588-40BC-88BE-44637B1AF0D9"

- description: Plan and implement IP addressing strategy to meet current and future requirements
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be more architectural guidance than a configuration for the Oracle resource that can be configured to improve the resiliency of the Oracle resource deployment. As such, wouldn't this better be addressed through WAF guidance?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation is agreed by relevant teams and as such we would like to keep it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @ehaslett this reads as a generic best practice rather than an actionable reliability recommendation.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basimolimajeed , due to the APRL requirements @ehaslett mentions above, this should be moved to WAF.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

being discussed

@oZakari oZakari closed this Oct 16, 2024
@oZakari oZakari reopened this Oct 16, 2024
@ehaslett
Copy link
Contributor

@ejhenry @basimolimajeed and myself are discussing via Teams to clarify the feedback and conversations within this PR.

@oZakari oZakari added the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Oct 24, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Nov 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Nov 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Nov 15, 2024
@terrymandin
Copy link

@ejhenry @basimolimajeed and myself are discussing via Teams to clarify the feedback and conversations within this PR.

@ejhenry, @basimolimajeed, and @ehaslett, please provide an update on this PR.

Seems we may need a new PR as the policy service closed it.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Nov 27, 2024
@ehaslett
Copy link
Contributor

@ejhenry @basimolimajeed and myself are discussing via Teams to clarify the feedback and conversations within this PR.

@ejhenry, @basimolimajeed, and @ehaslett, please provide an update on this PR.

Seems we may need a new PR as the policy service closed it.

It appears @basimolimajeed is still reviewing. I have no further updates at this point.

@oZakari oZakari reopened this Jan 7, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Jan 13, 2025

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Area: Resource Guidance 📝 Improvements or additions to documentation Enhancement 🆕 New feature or request Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants