Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SAP recommendations added #318

Merged
merged 15 commits into from
Sep 4, 2024
Merged

feat: SAP recommendations added #318

merged 15 commits into from
Sep 4, 2024

Conversation

humblejay
Copy link
Contributor

@humblejay humblejay commented Jul 29, 2024 •
edited by oZakari
Loading

Overview/Summary

Added SAP Netapp files & Storage related recommendations

Related Issues/Work Items

AVD ADO 36151

Breaking Changes

None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@humblejay humblejay requested review from a team as code owners July 29, 2024 03:35
@humblejay humblejay changed the title SAP recommendations added feat: SAP recommendations added Jul 29, 2024
@ejhenry ejhenry added Area: Resource Guidance 📝 Improvements or additions to documentation Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Jul 31, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Jul 31, 2024

@Azure/aprl-sap please review

@Azure Azure deleted a comment from azure-boards bot Aug 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Aug 1, 2024
PmeshramPM
PmeshramPM reviewed Aug 2, 2024
View reviewed changes
Copy link

@PmeshramPM PmeshramPM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @humblejay - On the links for ANF , please use these ones. These links have the Cluster parameter when you are using ANF for SUSE or RHEL clusters.

https://learn.microsoft.com/en-us/azure/sap/workloads/high-availability-guide-suse-nfs-simple-mount?tabs=lb-portal%2Censa1

https://learn.microsoft.com/en-us/azure/sap/workloads/high-availability-guide-suse-nfs-simple-mount?tabs=lb-portal%2Censa1

https://learn.microsoft.com/en-us/azure/sap/workloads/high-availability-guide-suse-netapp-files?tabs=lb-portal%2Censa1

https://learn.microsoft.com/en-us/azure/sap/workloads/high-availability-guide-suse-netapp-files?tabs=lb-portal%2Censa1

https://learn.microsoft.com/en-us/azure/sap/workloads/high-availability-guide-rhel-netapp-files?tabs=lb-portal%2Censa1

https://learn.microsoft.com/en-us/azure/sap/workloads/sap-hana-high-availability-netapp-files-red-hat?tabs=lb-portal

https://learn.microsoft.com/en-us/azure/sap/workloads/sap-hana-high-availability-netapp-files-suse?tabs=lb-portal

@oZakari oZakari added the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Aug 13, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Aug 20, 2024

@Azure/aprl-sap please review

@ejhenry ejhenry requested a review from PmeshramPM August 27, 2024 16:23
@oZakari oZakari added the Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity label Sep 2, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Enhancement 🆕 New feature or request and removed Status: No Recent Activity 🏜️ The issue or pull request has not had any recent activity labels Sep 2, 2024
PmeshramPM
PmeshramPM approved these changes Sep 2, 2024
View reviewed changes
Copy link

@PmeshramPM PmeshramPM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@oZakari oZakari merged commit 6e3c35d into main Sep 4, 2024
10 checks passed
@oZakari oZakari deleted the wip-kkp-sap branch September 4, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry left review comments

@oZakari oZakari oZakari approved these changes

@PmeshramPM PmeshramPM PmeshramPM approved these changes

Assignees

@humblejay humblejay

Labels
Area: Resource Guidance 📝 Improvements or additions to documentation Enhancement 🆕 New feature or request Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@humblejay @ejhenry @oZakari @PmeshramPM