Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated KQL for Azure Boost VMs #297

Closed
wants to merge 2 commits into from
Closed

feat: Updated KQL for Azure Boost VMs #297

wants to merge 2 commits into from

Conversation

khushal08
Copy link
Contributor

KQL for Azure Boost

Related Issues/Work Items

Breaking Changes

NA

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@khushal08 khushal08 requested a review from a team as a code owner July 19, 2024 06:29
@khushal08 khushal08 requested a review from ejhenry July 19, 2024 06:31
ejhenry
ejhenry reviewed Jul 19, 2024
View reviewed changes
Copy link
Contributor

@ejhenry ejhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @khushal08. Please include a screenshot of the results of your ARG testing in the PR.

@ejhenry ejhenry added Area: Resource Graph Query(s) #️⃣ Related to ARG queries Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author PR: Safe to Test ARG Queries 🧪 labels Jul 19, 2024
@khushal08
Copy link
Contributor Author

azure-boot-aprl
Attaching screenshot from testing

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Needs attention from aprl-maintainers and removed Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Jul 22, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Jul 23, 2024

@khushal08 it is not clear to me how the query aligns with the recommendation. If I read your query correctly, it is retrieving all boost VMs. Queries should retrieve resources that do not align with the recommendation. With this recommendation, we would also need to filter for maintenance sensitive workloads, unless our guidance is to recommend boost for all VMs.

@ejhenry ejhenry added the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Jul 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author label Jul 26, 2024
@khushal08
Copy link
Contributor Author

khushal08 commented Jul 26, 2024 •
edited
Loading

@ejhenry Updated the query to list non boost VMs. The idea is to list VMs for critical maintenance sensitive workloads where Azure Boost is not used. Query has no way to know if the workload is maintenance sensitive or not. This decision needs manual intervention.
What I suggest is let's go ahead with the query and let WARA CSA take a decision on workload sensitivity.

@oZakari oZakari changed the title Updated KQL for Azure Boost VMs feat: Updated KQL for Azure Boost VMs Jul 26, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Jul 29, 2024

@ejhenry Updated the query to list non boost VMs. The idea is to list VMs for critical maintenance sensitive workloads where Azure Boost is not used. Query has no way to know if the workload is maintenance sensitive or not. This decision needs manual intervention. What I suggest is let's go ahead with the query and let WARA CSA take a decision on workload sensitivity.

@khushal08 queries should not return false positives. In this case it sounds like we should instead note that the recommendation cannot be validated with ARG.

@oZakari oZakari added Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author and removed Needs: Attention 👋 Needs attention from aprl-maintainers labels Aug 1, 2024
@khushal08
Copy link
Contributor Author

@ejhenry Updated the query to list non boost VMs. The idea is to list VMs for critical maintenance sensitive workloads where Azure Boost is not used. Query has no way to know if the workload is maintenance sensitive or not. This decision needs manual intervention. What I suggest is let's go ahead with the query and let WARA CSA take a decision on workload sensitivity.

@khushal08 queries should not return false positives. In this case it sounds like we should instead note that the recommendation cannot be validated with ARG.

@ejhenry Closing this PR as discussed in ADO item.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 Needs attention from aprl-maintainers and removed Needs: Author Feedback 👂 The issue or pull request needs feedback from the original author labels Aug 7, 2024
@khushal08 khushal08 closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejhenry ejhenry ejhenry left review comments

Assignees
No one assigned
Labels
Area: Resource Graph Query(s) #️⃣ Related to ARG queries Needs: Attention 👋 Needs attention from aprl-maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khushal08 @ejhenry @oZakari