Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Line-breaks in learnMoreLink URLs #263

Merged
merged 32 commits into from
Sep 5, 2024
Merged

feat: Line-breaks in learnMoreLink URLs #263

merged 32 commits into from
Sep 5, 2024

Conversation

tksh164
Copy link
Member

@tksh164 tksh164 commented Jul 8, 2024

Overview/Summary

Fixed line breaks in learnMoreLink URLs.

image

Related Issues/Work Items

None

Breaking Changes

None

As part of this pull request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Performed testing and provided evidence (e.g. screenshot of output) for any changes associated to ARG queries
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

Screenshot

image

@tksh164 tksh164 requested a review from a team as a code owner July 8, 2024 07:49
@ejhenry ejhenry added the Area: Tools 🧰 Related to the tools directory and/or content label Jul 8, 2024
oZakari
oZakari previously approved these changes Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@oZakari oZakari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tksh164

@oZakari oZakari added the Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team label Jul 10, 2024
@oZakari oZakari requested a review from a team July 10, 2024 03:11
@oZakari oZakari requested a review from kpoineal July 17, 2024 17:31
@tksh164 tksh164 changed the title Fix line breaks in learnMoreLink URLs feat: Line-breaks in learnMoreLink URLs Jul 24, 2024
@tksh164
Copy link
Member Author

tksh164 commented Aug 1, 2024

@caseywatson @kpoineal @Claudio-Merola Would you be willing to review this PR? This PR has been over 3 weeks with no reviews. Thanks.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Enhancement 🆕 New feature or request label Aug 26, 2024
@ejhenry
Copy link
Contributor

ejhenry commented Sep 5, 2024

@kpoineal @Claudio-Merola please review

kpoineal
kpoineal approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@kpoineal kpoineal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple fix. Sorry it took so long to get to this. Approved on my end.

@tksh164 tksh164 merged commit c22833a into Azure:main Sep 5, 2024
4 checks passed
@tksh164 tksh164 deleted the fix-learn-more-link-linebreak branch September 5, 2024 05:52
tksh164 added a commit that referenced this pull request Sep 19, 2024
@tksh164
Fix regression by #411
5354c80 
Line-breaks for link URLs in LearnMore column add by PR #263. But PR #411 makes regression on this.
#263
@tksh164 tksh164 mentioned this pull request Sep 19, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oZakari oZakari oZakari approved these changes

@kpoineal kpoineal kpoineal approved these changes

Assignees

@caseywatson caseywatson

@kpoineal kpoineal

@Claudio-Merola Claudio-Merola

Labels
Area: Tools 🧰 Related to the tools directory and/or content Enhancement 🆕 New feature or request Needs: Attention from aprl-wara-tools 👋 Needs attention from aprl-wara-tools GitHub team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tksh164 @ejhenry @oZakari @kpoineal @caseywatson @Claudio-Merola