feat: update n_tps benchmark #18683
Merged
feat: update n_tps benchmark #18683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexghr
commented
Nov 28, 2025
Comment on lines
316
to
325
| console.log(` | ||
| Histogram: | ||
| Records: ${histo.count} | ||
| Min : ${histo.min} | ||
| Max : ${histo.max} | ||
| Mean : ${histo.mean} | ||
| Median : ${histo.percentile(50)} | ||
| Perc90 : ${histo.percentile(90)} | ||
| Perc95 : ${histo.percentile(95)} | ||
| Perc99 : ${histo.percentile(99)} |
Contributor
Author
There was a problem hiding this comment.
Hmm, I can't keep this as a console.log
alexghr
force-pushed
the
ag/bench
branch
2 times, most recently
from
d0d8ca5 to
03f1fae
Compare
PhilWindle
approved these changes
Nov 29, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 1, 2025
BEGIN_COMMIT_OVERRIDE feat: update n_tps benchmark (#18683) chore: update test END_COMMIT_OVERRIDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following updates to the TPS benchmark:
Fix A-327 A-331