Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for that awesome script.
I've think its possible to rename RTTI class member functions according to linux one if there same vtable size.
Also i fixed _get_xref_to_calls function:
I think there was problem
xref.to
was always same asea
thats why_multiple_xrefs_search
was not worked as excepted.Also maybe rtti renamer function should be rewritted, but im not good at python atm :-)
Here's some results with current implementation on some client dll+so from Half-Life 1:
3 Is looks good but since vtables size mismatch i think in this case we can add some symbol before function like
!!CBaseMonster::TraceAttack
to indicate that function mb incorrectRTTI scripts are from: https://github.com/nccgroup/SusanRTTI with little modification to scan vtable functions addresses