Skip to content

fix: update foreign key handling to use 'reference' #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AxiosLeo merged 5 commits into from
Feb 23, 2026
Merged

fix: update foreign key handling to use 'reference' #25

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
97fa1d1
fix(builder, migration): update foreign key handling to use 'referenc…
AxiosLeo Feb 23, 2026
e51714b
fix(builder): rename 'reference' to 'references' for improved consist…
AxiosLeo Feb 23, 2026
e0c13b7
fix(tests): update 'reference' to 'references' in builder tests for c…
AxiosLeo Feb 23, 2026
cf36df6
fix(builder): add checks for references in createForeignKey and handl…
AxiosLeo Feb 23, 2026
ac909d1
fix(migration): adjust reference handling in _initMigration for impro…
AxiosLeo Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,25 +583,25 @@ class ManageSQLBuilder extends Builder {
}

createForeignKey(options) {
options.reference.onDelete = options.reference.onDelete ? options.reference.onDelete.toUpperCase() : 'NO ACTION';
options.reference.onUpdate = options.reference.onUpdate ? options.reference.onUpdate.toUpperCase() : 'NO ACTION';
options.references.onDelete = options.references.onDelete ? options.references.onDelete.toUpperCase() : 'NO ACTION';
options.references.onUpdate = options.references.onUpdate ? options.references.onUpdate.toUpperCase() : 'NO ACTION';
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
_validate(options, {
name: 'required|string',
table: 'required|string',
column: 'required|string',
'reference.tableName': 'required|string',
'reference.columnName': 'required|string',
'reference.onUpdate': [{ in: ['RESTRICT', 'CASCADE', 'SET NULL', 'NO ACTION'] }],
'reference.onDelete': [{ in: ['RESTRICT', 'CASCADE', 'SET NULL', 'NO ACTION'] }]
'references.tableName': 'required|string',
'references.columnName': 'required|string',
'references.onUpdate': [{ in: ['RESTRICT', 'CASCADE', 'SET NULL', 'NO ACTION'] }],
'references.onDelete': [{ in: ['RESTRICT', 'CASCADE', 'SET NULL', 'NO ACTION'] }]
});
return _render('ALTER TABLE `${table_name}` ADD CONSTRAINT `${name}` FOREIGN KEY (`${column_name}`) REFERENCES `${foreign_table}` (`${foreign_column}`) ON DELETE ${on_delete} ON UPDATE ${on_update}', {
table_name: options.tableName,
name: options.name,
column_name: options.columnName,
foreign_table: options.reference.tableName,
foreign_column: options.reference.columnName,
on_delete: options.reference.onDelete || 'NO ACTION',
on_update: options.reference.onUpdate || 'NO ACTION',
foreign_table: options.references.tableName,
foreign_column: options.references.columnName,
on_delete: options.references.onDelete || 'NO ACTION',
on_update: options.references.onUpdate || 'NO ACTION',
Comment thread
cursor[bot] marked this conversation as resolved.
});
}

Expand Down
2 changes: 1 addition & 1 deletion src/migration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ function _initMigration(file, queries = {}) {
name: options.foreignKey ? options.foreignKey : 'fk_' + table + '_' + options.columnName,
table: table,
column: options.columnName,
reference: options.reference
references: options.reference || options.references // 兼容性处理
Comment thread
cursor[bot] marked this conversation as resolved.
Outdated
});
const builder = new ManageSQLBuilder(options);
queries[file].push({ sql: builder.sql, values: builder.values });
Expand Down
Loading