Conversation
…ve URL construction with protocol and host detection
… sending data by connection and connection ID
…et connection and specify connection ID type
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…r improved handling
…pp event emissions in socket workflow
…ocketContext; update Application class config type
…s in SocketApplication and WebSocketApplication
…ation for enhanced connection management
…g connections tracking and reorganizing sendByConnectionId method
…ketApplication and WebSocketApplication, including class hierarchy, setup examples, and connection management methods
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1d64ee9. Configure here.
…functions, Model, response handling, Router, SSE middleware, utility functions, and workflow management
…nnecessary properties for cleaner configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches core
SocketApplication/WebSocketApplicationruntime behavior (connection lifecycle, ping, and URL parsing), which could affect existing socket clients. Added tests reduce risk but changes are in a central request/response path.Overview
WebSocket server is refactored to extend
SocketApplicationso it reuses shared connection tracking, ping configuration (pingConfig), and newly added connection management helpers.Socket and WebSocket request dispatch now populate
context.connection_id, and the WebSocket URL parsing is updated to respectHostandx-forwarded-protoheaders for correctws/wsshandling.TypeScript declarations are updated to reflect the new class hierarchy and APIs (new
PingConfig,send/close/getConnection/sendByConnectionId), CI now tests Node22/24, ESLint targets ES2020, and a comprehensive test suite is added alongside updated websocket example/docs.Reviewed by Cursor Bugbot for commit b47da55. Bugbot is set up for automated code reviews on this repo. Configure here.