chore(deps): Bump rand from 0.8.6 to 0.9.2#66
Conversation
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
14f4c57 to
37d14fe
Compare
37d14fe to
7a872f5
Compare
Bumps [rand](https://github.com/rust-random/rand) from 0.8.6 to 0.9.2. - [Release notes](https://github.com/rust-random/rand/releases) - [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md) - [Commits](rust-random/rand@0.8.6...rand_core-0.9.2) --- updated-dependencies: - dependency-name: rand dependency-version: 0.9.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
7a872f5 to
810ec1f
Compare
|
Holding this one: rand 0.8 -> 0.9 is a breaking major and the workspace does not compile after the bump (deprecated Rng::gen -> random, rand::distributions moved to rand::distr, ChaCha8Rng::seed_from_u64 signature change, StandardNormal::sample changes). dependabot only bumped the manifests, not the call sites. These usages live in the sampler RNG (spark-runtime) and KV/storage paths, so the migration is not purely mechanical: changing the RNG construction/stream can shift which tokens are drawn at temperature > 0. That deserves a deliberate migration PR with a determinism check, not an auto-merge. Leaving open until that is done; same applies to the rand_distr bump in #65 which depends on this. |
|
Closing this one deliberately. With current main the resolver actually pulls rand 0.10, an even larger breaking jump than 0.9, and the breakage lands squarely in the sampler RNG (Rng::gen -> random, rand::distributions -> rand::distr, ChaCha8Rng::seed_from_u64, StandardNormal::sample) plus the storage path. A faithful migration is doable, but it is a deliberate change that needs a token-stream determinism check (temp>0 sampling must not silently shift), not an auto-bump, and the value here is only dependency freshness. Declining for now; dependabot will resurface it, and we will do it as a focused migration PR when it is worth the verification. Same reasoning closes #65. |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps rand from 0.8.6 to 0.9.2.
Changelog
Sourced from rand's changelog.
... (truncated)
Commits
d3dd415Prepare rand_core 0.9.2 (#1605)99fabd2Prepare rand_core 0.9.2c7fe1c4rand: re-exportrand_core(#1604)db2b1e0rand: re-exportrand_coreee1d96frand_core: implement reborrow forUnwrapMut(#1595)e0eb2eerand_core: implement reborrow forUnwrapMut975f602fixup clippy 1.85 warnings775b05bRelaxSizedrequirements for blanket impls (#1593)ec6d5c0Prepare rand_core v0.9.1 (#1591)6a06056rand_core: introduce an UnwrapMut wrapper (#1589)