Bump MicroCOM, add workaround for WinRT bug#20992
Open
Conversation
|
You can test this PR using the following package version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WinRT has broken reference counting for effects returned from GetSource. It will Release returned ref
and attempt to use it afterward:
Details
This usually works because the wrapper effect DOES hold a reference to the COM object, so invalid memory access succeeds. In our case MicroCOM will rightfully release native memory once the latest native reference is gone.
So we need to keep CCWs alive for the entire call as a workaround.
This PR bumps MicroCOM to 0.11.4 and adds some .props that allow referencing it directly from source.