Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: RadioButton IsChecked displayed incorrectly when switching ViewModel. #17765

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LucasYao93
Copy link

@LucasYao93 LucasYao93 commented Dec 13, 2024

What is the current behavior?

RB_Issue.mp4

What is the updated/expected behavior with this PR?

RadioButton IsChecked displayed incorrectly when switching ViewModel.

How was the solution implemented (if it's not obvious)?

  1. Remove RadioButtonGroupManager.s_default.
  2. Add RadioButton to RadioButtonGroup only when it is mounted to VisualTree.
  3. Do not add RadioButton to RadioButtonGroup when it already exists.

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

#5612

@LucasYao93 LucasYao93 marked this pull request as draft December 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant