Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains Management Revamp: Add email plans comparison subpage #97944

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

phcp
Copy link
Contributor

@phcp phcp commented Jan 3, 2025

Closes #97815

Proposed Changes

  • Add Email Plans Comparison subpage.
  • Fix vertical scrolling for subpages.
  • Update tests.

Why are these changes being made?

  • This is part of the Domain Management Revamp project: pfuQfP-13x-p2

Testing Instructions

  • Apply this PR to your local
  • Go to http://calypso.localhost:3000/domains/manage?flags=calypso/all-domain-management
  • Click on a domain that doesn't have emails configured
  • Click on the Email tab
  • Click on "See how they compare" link
  • The plans comparison page should be rendered with the new layout
  • Select one of the email plans
  • It should return to the Email overview page with the correct plan expanded
  • Go back to the plans comparison page
  • Switch to Monthly plans and select a different plan
  • It should return to the Email overview page with the correct interval selected and the plan expanded
  • Go to the old UI and perform the same tests (WP Admin -> Hosting -> Email)
  • The page should work as before, without changes on visual or behavior

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@phcp phcp requested a review from a team January 3, 2025 18:35
@phcp phcp self-assigned this Jan 3, 2025
@phcp phcp requested a review from a team as a code owner January 3, 2025 18:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 3, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~41 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +118 B  (+0.0%)      +24 B  (+0.0%)
entry-login                 +118 B  (+0.0%)      +24 B  (+0.0%)
entry-domains-landing       +118 B  (+0.0%)      +20 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~92 bytes added 📈 [gzipped])

name                  parsed_size           gzip_size
domains                    +796 B  (+0.0%)      +77 B  (+0.0%)
update-design-flow         +118 B  (+0.0%)      +15 B  (+0.0%)
link-in-bio-tld-flow       +118 B  (+0.0%)      +15 B  (+0.0%)
copy-site-flow             +118 B  (+0.0%)      +15 B  (+0.0%)
email                       +81 B  (+0.0%)      +10 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~54 bytes added 📈 [gzipped])

name                                                                              parsed_size           gzip_size
async-load-signup-steps-page-picker                                                    +118 B  (+0.0%)      +17 B  (+0.0%)
async-load-signup-steps-domains                                                        +118 B  (+0.0%)      +15 B  (+0.0%)
async-load-purchase-modal-wrapper                                                      +118 B  (+0.0%)      +17 B  (+0.0%)
async-load-my-sites-checkout-purchase-modal-is-eligible-for-one-click-checkou...       +118 B  (+0.0%)      +17 B  (+0.0%)
async-load-calypso-my-sites-checkout-modal                                             +118 B  (+0.0%)      +22 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@ouikhuan ouikhuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works as expected! 🚢

@phcp phcp merged commit 8d698c1 into trunk Jan 6, 2025
15 checks passed
@phcp phcp deleted the add/domains-management-plans-comparison branch January 6, 2025 14:46
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create plan comparison page
3 participants