Skip to content

Conversation

@matticbot
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
automattic/jetpack-codesniffer require-dev patch ^2.1 -> ^2.8.0

Configuration

📅 Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@matticbot matticbot added [Type] Task dependencies Pull requests that update a dependency file Framework labels Mar 2, 2024
@matticbot matticbot requested review from a team March 2, 2024 02:09
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 2, 2024
@github-actions
Copy link

github-actions bot commented Mar 2, 2024

@matticbot
Copy link
Contributor Author

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug renovate/automattic-jetpack-codesniffer-2.x on your sandbox.

@matticbot
Copy link
Contributor Author

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@tyxla
Copy link
Member

tyxla commented Mar 4, 2024

I see @kraftbj changed ETK to the Jetpack codesniffer back in #49579 - do you think you can take a look? Or perhaps think about who else we can ping to take a look?

@tyxla tyxla requested review from a team and kraftbj and removed request for a team March 4, 2024 11:18
@anomiex
Copy link
Contributor

anomiex commented Mar 4, 2024

tyxla requested review from Automattic/jetpack-garage

🤷

I see running vendor/bin/phpcs --standard=apps/phpcs.xml still passes. Also, I see the lockfile already had 2.8.0 since #79266 (since 2.8.0 satisfies the ^2.1 dep), so there's no functionality change here.

@tyxla
Copy link
Member

tyxla commented Mar 4, 2024

You're right 👍 Thanks for confirming!

@tyxla tyxla merged commit 8cf409d into trunk Mar 4, 2024
@tyxla tyxla deleted the renovate/automattic-jetpack-codesniffer-2.x branch March 4, 2024 15:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file Framework [Type] Task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants