Skip to content

Conversation

@sixhours
Copy link
Contributor

@sixhours sixhours commented Jul 19, 2023

Related to #78812 (comment)

Proposed Changes

  • Following up on the changes made to the Badge component, this localizes a couple of support-related URLs that were flagged by the linter.

Testing Instructions

  • I'm not sure how to test this since it looks like these URLs only show up when there's an error with a Blaze campaign, or a proposed campaign post violates the ToS. I've cc'ed folks who've recently worked on this file for assistance. :)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@sixhours sixhours requested review from a team and noahtallen July 19, 2023 18:22
@sixhours sixhours self-assigned this Jul 19, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 19, 2023
@github-actions
Copy link

github-actions bot commented Jul 19, 2023

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~34 bytes added 📈 [gzipped])

Details
name          parsed_size           gzip_size
promote-post        +85 B  (+0.0%)      +34 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@noahtallen noahtallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

btw, this might get fixed as well when #78711 gets merged -- since that PR touched so many files, it fixes some random lint warnings around the codebase.

Copy link
Contributor

@sbarbosa sbarbosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

@sixhours sixhours merged commit f0cbffb into trunk Jul 20, 2023
@sixhours sixhours deleted the fix/localize-urls branch July 20, 2023 15:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants