CI: remove unused configurations and further tweaks to filter unnecessary builds. #78973
Conversation
- remove unused configs
- expand vcs do not trigger rules for the WPComPlugin builds.
- remove reference to HelpCentreE2ETests
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
- remove unused config keys. - remove use of `JEST_MAX_WORKERS` in favor of using `JEST_E2E_WORKERS`.
| } | ||
| ) | ||
|
|
||
| object HelpCentreE2ETests : E2EBuildType( |
There was a problem hiding this comment.
These configurations were never used or no longer used.
- unbound variable
matticbot
added
the
[Status] Needs Review
noahtallen
left a comment
noahtallen
left a comment
There was a problem hiding this comment.
Looks good, thanks for the cleanup!
| scriptContent = """ | ||
| cd apps/editing-toolkit | ||
| yarn test:js --reporters=default --reporters=jest-teamcity --maxWorkers=${'$'}JEST_MAX_WORKERS | ||
| yarn test:js --reporters=default --reporters=jest-teamcity --maxWorkers=%JEST_E2E_WORKERS% |
There was a problem hiding this comment.
For the merge conflict, just a heads up that I moved the unit tests here from calypso apps to the primary unit test build config in #79097.
There was a problem hiding this comment.
Ah gotcha, I'll take a look. Thanks!
There was a problem hiding this comment.
@roo2 Thanks for the heads up. I'll merge my changes in since it should not cause any issues with existing builds, but that means I'd be shifting the conflict resolution burden onto @noahtallen - hope you don't mind.
github-actions
bot
removed
the
[Status] Needs Review
Proposed Changes
This PR is partly chore, partly enhancement to the CI.
Key changes:
test/e2e/packages/calypso-e2eHelpCentreE2EandKPIDashboardTests.Testing Instructions
Ensure the following build configurations are passing:
Additionally, ensure no build has the "Failed to load settings from VCS" error.
Pre-merge Checklist