Correctly build whats-new with typescript #78762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
Contributor
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
noahtallen
force-pushed
the
try-convert-whats-new-ts
branch
from
5f0eb69 to
d5ee49f
Compare
noahtallen
commented
Jul 20, 2023
noahtallen
force-pushed
the
try-convert-whats-new-ts
branch
from
d5ee49f to
d779718
Compare
Contributor
Author
|
Turns out that we just needed to update Typescript and it works now :) I think that makes sense, as TS tweaked/updated a lot of DOM types over the several releases we just updated. |
Contributor
Author
|
I'm going to move forward with this, since CI has verified the major pieces! Happy to follow-up with feedback |
github-actions
bot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
While working on #78711, I was troubleshooting a type error in this package and noticed that while it's written entirely in TS, the build system doesn't reflect that. I made various changes to the package to match other packages which are build by TS. Additionally, I removed the typings file, since none of it is needed any more.
Testing Instructions
cd packages/whats-new && yarn build-- does it work, and do files indistlook correct?To do:
HTMLElement.