Skip to content

Reader: add an editor for creating new posts #75475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
creativecoder wants to merge 5 commits into from
Closed

Reader: add an editor for creating new posts #75475

creativecoder wants to merge 5 commits into from

Conversation

@creativecoder
Copy link
Contributor

@creativecoder creativecoder commented Apr 10, 2023

Related to #

Proposed Changes

This is an experiment with using IsolatedBlockEditor within the reader to create new posts.

Testing Instructions

  • Go to /read
  • Try creating a new post and publishing it

@creativecoder creativecoder added the [Feature] Reader The reader site on Calypso. label Apr 10, 2023
@creativecoder creativecoder self-assigned this Apr 10, 2023
@creativecoder creativecoder marked this pull request as ready for review April 10, 2023 12:47
@creativecoder creativecoder requested a review from a team as a code owner April 10, 2023 12:47
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 10, 2023
@matticbot
Copy link
Contributor

matticbot commented Apr 10, 2023

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-62900
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-62900&env=jetpack

@creativecoder creativecoder added [Status] Blocked / Hold and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 10, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 10, 2023
@matticbot
Copy link
Contributor

matticbot commented Apr 10, 2023

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~1871 bytes added 📈 [gzipped])

Details 
name                   parsed_size           gzip_size
entry-main                +14008 B  (+0.9%)     +685 B  (+0.2%)
entry-stepper             +13954 B  (+0.5%)    +1307 B  (+0.2%)
entry-login                 +544 B  (+0.0%)      +61 B  (+0.0%)
entry-browsehappy           +504 B  (+0.5%)      +50 B  (+0.2%)
entry-domains-landing       +495 B  (+0.1%)      +46 B  (+0.0%)
entry-subscriptions         +493 B  (+0.0%)      +49 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~470921 bytes added 📈 [gzipped])

Details 
name                               parsed_size             gzip_size
reader                              +2542432 B  (+329.4%)  +717849 B  (+311.5%)
pattern-assembler-step               +370621 B   (+36.7%)  +103581 B   (+35.3%)
import-flow                          +370491 B   (+14.2%)  +103197 B   (+15.2%)
gutenberg-editor                       +5433 B    (+0.8%)    +1813 B    (+0.9%)
newsletter-flow                        -1539 B    (-0.2%)     +391 B    (+0.2%)
home                                   -1366 B    (-0.1%)     -512 B    (-0.1%)
write-flow                             -1364 B    (-0.6%)     -225 B    (-0.5%)
videopress-flow                        -1364 B    (-0.3%)      +90 B    (+0.1%)
update-design-flow                     -1364 B    (-0.2%)     +229 B    (+0.2%)
signup                                 -1364 B    (-0.5%)      -84 B    (-0.1%)
link-in-bio-tld-flow                   -1364 B    (-0.2%)     +143 B    (+0.1%)
link-in-bio-flow                       -1364 B    (-0.2%)     +121 B    (+0.1%)
free-flow                              -1364 B    (-0.5%)     -154 B    (-0.2%)
build-flow                             -1364 B    (-0.6%)     -223 B    (-0.5%)
accept-invite                          -1364 B    (-0.4%)      -84 B    (-0.1%)
jetpack-connect                        -1340 B    (-0.1%)     -136 B    (-0.0%)
purchases                               -847 B    (-0.0%)    -2046 B    (-0.4%)
settings-writing                        +587 B    (+0.1%)      -61 B    (-0.0%)
site-purchases                          -550 B    (-0.0%)    -2503 B    (-0.6%)
marketplace                             -447 B    (-0.1%)    -2177 B    (-0.8%)
domains                                 -391 B    (-0.0%)    -1847 B    (-0.4%)
settings                                -372 B    (-0.0%)     -954 B    (-0.4%)
site-blocks                             -365 B    (-0.0%)     -654 B    (-0.3%)
me                                      -330 B    (-0.0%)     -494 B    (-0.3%)
happychat                               -330 B    (-0.0%)     -921 B    (-0.5%)
privacy                                 -328 B    (-0.0%)     -741 B    (-0.4%)
scan                                    +323 B    (+0.0%)    +1004 B    (+0.4%)
backup                                  +323 B    (+0.0%)    +1171 B    (+0.4%)
activity                                +323 B    (+0.0%)    +1386 B    (+0.6%)
with-theme-assembler-flow               +309 B    (+8.8%)      +94 B    (+7.4%)
people                                  -288 B    (-0.0%)     -935 B    (-0.4%)
plugin-bundle-flow                      +285 B    (+0.3%)     -199 B    (-0.7%)
site-setup-flow                         +268 B    (+0.0%)     -728 B    (-0.2%)
security                                -235 B    (-0.0%)     -553 B    (-0.2%)
theme                                   +209 B    (+0.0%)     -135 B    (-0.1%)
jetpack-cloud-partner-portal            -182 B    (-0.0%)      -42 B    (-0.0%)
newsletter-post-setup-flow              -175 B    (-0.1%)     +167 B    (+0.3%)
jetpack-cloud-plugin-management         -172 B    (-0.0%)    -1227 B    (-0.4%)
account                                 -166 B    (-0.0%)     +292 B    (+0.1%)
checkout                                +154 B    (+0.0%)     -933 B    (-0.2%)
sites-dashboard                         -140 B    (-0.0%)      -86 B    (-0.1%)
account-close                           -134 B    (-0.0%)     -294 B    (-0.1%)
devdocs                                 +125 B    (+0.1%)      +53 B    (+0.1%)
import                                  -106 B    (-0.0%)     -493 B    (-0.3%)
themes                                  -100 B    (-0.0%)     -236 B    (-0.1%)
preview                                 -100 B    (-0.0%)      -94 B    (-0.1%)
posts-custom                            -100 B    (-0.0%)      -86 B    (-0.0%)
posts                                   -100 B    (-0.0%)      -86 B    (-0.0%)
pages                                   -100 B    (-0.0%)      -91 B    (-0.0%)
plugins                                  +77 B    (+0.0%)      +60 B    (+0.0%)
notification-settings                    -66 B    (-0.0%)    +1066 B    (+0.4%)
help                                     +64 B    (+0.0%)      -30 B    (-0.0%)
woocommerce-installation                 +24 B    (+0.0%)      -53 B    (-0.0%)
woocommerce                              +24 B    (+0.0%)      -53 B    (-0.0%)
stats                                    +24 B    (+0.0%)      -53 B    (-0.0%)
site-logs                                +24 B    (+0.0%)      -53 B    (-0.0%)
settings-security                        +24 B    (+0.0%)      -53 B    (-0.0%)
settings-reading                         +24 B    (+0.0%)      -53 B    (-0.0%)
settings-performance                     +24 B    (+0.0%)      -53 B    (-0.0%)
settings-jetpack                         +24 B    (+0.0%)      -53 B    (-0.0%)
settings-discussion                      +24 B    (+0.0%)      -53 B    (-0.0%)
promote-post                             +24 B    (+0.0%)      -53 B    (-0.0%)
migrate                                  +24 B    (+0.0%)      -53 B    (-0.0%)
marketing                                +24 B    (+0.0%)      -53 B    (-0.0%)
jetpack-social                           +24 B    (+0.0%)      -53 B    (-0.0%)
jetpack-search                           +24 B    (+0.0%)      -53 B    (-0.0%)
jetpack-cloud-settings                   +24 B    (+0.0%)      -53 B    (-0.0%)
jetpack-cloud-pricing                    +24 B    (+0.0%)      -52 B    (-0.0%)
jetpack-cloud-features-comparison        +24 B    (+0.0%)      -52 B    (-0.0%)
jetpack-cloud-agency-dashboard           +24 B    (+0.0%)      -66 B    (-0.0%)
jetpack-cloud                            +24 B    (+0.0%)      -53 B    (-0.0%)
hosting                                  +24 B    (+0.0%)      -53 B    (-0.0%)
google-my-business                       +24 B    (+0.0%)      -53 B    (-0.0%)
export                                   +24 B    (+0.0%)      -53 B    (-0.0%)
email                                    +24 B    (+0.0%)     +278 B    (+0.1%)
earn                                     +24 B    (+0.0%)      -53 B    (-0.0%)
customize                                +24 B    (+0.0%)      -53 B    (-0.0%)
concierge                                +24 B    (+0.0%)      -53 B    (-0.0%)
comments                                 +24 B    (+0.0%)      -53 B    (-0.0%)
add-ons                                  +24 B    (+0.0%)      -53 B    (-0.0%)
media                                    -13 B    (-0.0%)     -486 B    (-0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~29453 bytes added 📈 [gzipped])

Details 
name                                                                 parsed_size            gzip_size
async-load-automattic-design-preview                                   +369156 B  (+38.2%)  +103477 B  (+36.7%)
async-load-automattic-design-preview-src-components-style-variation    +368223 B  (+36.0%)  +103363 B  (+34.5%)
async-load-calypso-reader-site-stream                                   -12946 B  (-18.8%)    -3921 B  (-18.2%)
async-load-calypso-reader-search-stream                                 -12946 B  (-10.3%)    -3875 B  (-10.9%)
async-load-calypso-reader-following-manage                              -12946 B   (-8.8%)    -3875 B   (-9.2%)
async-load-calypso-reader-feed-stream                                   -12946 B  (-18.8%)    -3921 B  (-18.2%)
async-load-automattic-help-center                                         -623 B   (-0.1%)     -906 B   (-0.4%)
async-load-signup-steps-woocommerce-install-step-store-address            +274 B   (+0.1%)     -509 B   (-0.6%)
async-load-calypso-blocks-inline-help                                     -248 B   (-1.9%)      -59 B   (-1.5%)
async-load-design-blocks                                                  -199 B   (-0.0%)     +766 B   (+0.1%)
async-load-masterbar-help-center                                          -182 B   (-0.6%)      -36 B   (-0.4%)
async-load-calypso-layout-masterbar-checkout                              -182 B   (-0.2%)      -36 B   (-0.1%)
async-load-calypso-blocks-editor-checkout-modal                           -182 B   (-0.0%)      -36 B   (-0.0%)
async-load-signup-steps-site-picker                                       -172 B   (-0.1%)     -800 B   (-0.7%)
async-load-signup-steps-difm-site-picker                                  -172 B   (-0.1%)     -864 B   (-0.8%)
async-load-calypso-components-sites-popover                               -172 B   (-0.1%)     -931 B   (-0.9%)
async-load-calypso-post-editor-media-modal                                -130 B   (-0.0%)     -393 B   (-0.1%)
async-load-calypso-components-web-preview-component                       -129 B   (-0.0%)    -1084 B   (-0.7%)
async-load-publish                                                        -124 B   (-0.2%)      -53 B   (-0.3%)
async-load-calypso-my-sites-stats-stats-post-detail                       -124 B   (-0.3%)      -37 B   (-0.3%)
async-load-calypso-my-sites-site-settings-seo-settings-form               -124 B   (-0.0%)      -36 B   (-0.0%)
async-load-design-wordpress-components-gallery                             -85 B   (-0.0%)     +172 B   (+0.1%)
async-load-calypso-layout-masterbar-checkout-tsx                           -51 B   (-0.0%)      -12 B   (-0.0%)
async-load-signup-steps-woocommerce-install-transfer                       +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-woocommerce-install-step-business-info             +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-woocommerce-install-confirm                        +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-woocommerce-install                                +42 B   (+0.0%)      +31 B   (+0.1%)
async-load-signup-steps-website-content                                    +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-user                                               +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-theme-selection                                    +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-test-step                                          +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-store-features                                     +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-starting-point                                     +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-social-profiles                                    +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-site-type                                          +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-site-title                                         +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-site-or-domain                                     +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-site-options                                       +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-site                                               +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-rewind-were-backing                                +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-rewind-migrate                                     +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-rewind-form-creds                                  +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-reader-landing                                     +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-plans-pm                                           +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-plans-atomic-store                                 +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-plans                                              +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-page-picker                                        +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-p2-site                                            +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-p2-join-workspace                                  +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-p2-get-started                                     +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-p2-details                                         +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-p2-confirm-email                                   +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-p2-complete-profile                                +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-new-or-existing-site                               +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-intent                                             +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-emails                                             +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-domains                                            +42 B   (+0.0%)     +463 B   (+0.3%)
async-load-signup-steps-creds-permission                                   +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-creds-confirm                                      +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-creds-complete                                     +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-courses                                            +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-clone-start                                        +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-clone-ready                                        +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-clone-point                                        +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-clone-jetpack                                      +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-clone-destination                                  +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-clone-credentials                                  +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-clone-cloning                                      +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-signup-steps-add-ons                                            +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-quick-language-switcher                                         +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-design-playground                                               +42 B   (+0.0%)     +233 B   (+0.0%)
async-load-calypso-lib-account-settings-helper                             +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-calypso-blocks-jitm-templates-modal                             +42 B   (+0.0%)      +31 B   (+0.0%)
async-load-design                                                          -37 B   (-0.0%)      +42 B   (+0.0%)
async-load-calypso-post-editor-editor-media-modal                          -37 B   (-0.0%)     +154 B   (+0.0%)
async-load-signup-steps-design-picker                                      +26 B   (+0.0%)      +35 B   (+0.0%)
async-load-calypso-blocks-inline-help-popover                              -15 B   (-0.0%)     -585 B   (-0.3%)
async-load-calypso-my-sites-checkout-modal                                 +14 B   (+0.0%)     +504 B   (+0.2%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@creativecoder
Copy link
Contributor Author

creativecoder commented Apr 20, 2023

Replaced by #76035. Closing to keep this as is, for reference.

@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 20, 2023
@creativecoder creativecoder mentioned this pull request May 1, 2023
Closed
@sirreal sirreal deleted the try/reader-isolated-block-editor branch January 14, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@creativecoder creativecoder

Labels

DO NOT MERGE [Feature] Reader The reader site on Calypso. [Status] Blocked / Hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@creativecoder @matticbot