Skip to content

Conversation

@xavier-lc
Copy link
Contributor

Fixes DOTTHEM-16

Proposed Changes

  • When a user chooses to preview a theme with their own content after having selected a theme style, persist that selection so that it shows up as well on the site editor.

Why are these changes being made?

  • Letting users choose a style and then not showing it is confusing.

Testing Instructions

  • Open the live preview
  • Go to /theme/twentytwentyfive/{siteSlug}
  • Click on a style
  • Click on Preview
  • Click on Preview with your content
  • Check that the site editor reflects the chose style

chrome-capture-2026-01-30

  • Go back to /theme/twentytwentyfive/{siteSlug}, check that it shows with the style chosen before
  • Choose another style
  • Click on Preview
  • Click on Preview with demo content
  • Click on Preview with your content
  • Check that the site editor reflects the chose style

chrome-capture-2026-01-30 (1)

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@xavier-lc xavier-lc self-assigned this Jan 30, 2026
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2026

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • odyssey-stats

To test WordPress.com changes, run install-plugin.sh $pluginSlug DOTTHEM-16/themes-try-and-customize-doesnt-apply-selected-style-variation on your sandbox.

Xavier Lozano Carreras added 3 commits January 30, 2026 19:33
…ed-style-variation' of github.com:Automattic/wp-calypso into DOTTHEM-16/themes-try-and-customize-doesnt-apply-selected-style-variation
@xavier-lc xavier-lc closed this Feb 2, 2026
@xavier-lc xavier-lc deleted the DOTTHEM-16/themes-try-and-customize-doesnt-apply-selected-style-variation branch February 2, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants