Skip to content

DNS: Hide email setup when not using WordPress.com nameservers #108448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
gius80 wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

DNS: Hide email setup when not using WordPress.com nameservers #108448

gius80 wants to merge 2 commits into from

Conversation

@gius80
Copy link
Contributor

@gius80 gius80 commented Jan 30, 2026 •
edited
Loading

Closes DOMENG-282

Proposed Changes

  • Hide the EmailSetup component on the DNS records page when the domain is not using WordPress.com nameservers
  • Applies to both the Calypso interface and the MSD

Why are these changes being made?

  • DNS records configured through the EmailSetup component won't take effect when the domain uses external nameservers
  • Hiding the component avoids user confusion and provides a cleaner experience

Testing Instructions

  • Navigate to a domain's DNS records page that uses WordPress.com nameservers → EmailSetup section should be visible
  • Navigate to a domain's DNS records page that uses external nameservers → EmailSetup section should be hidden
  • Test both in the Calypso interface and the MSD.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@gius80 @claude
DNS: Hide email setup when not using WordPress.com nameservers
957cf48 
The EmailSetup component is only useful when the domain is using
WordPress.com nameservers, since DNS records configured through it
won't take effect otherwise.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
@gius80 gius80 requested a review from a team as a code owner January 30, 2026 17:17
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2026
@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited by matticbot
Loading

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-168085
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-168085&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-168085&env=a8c-for-agencies
Dashboard live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:build-168085&env=dashboard

@gius80 gius80 self-assigned this Jan 30, 2026
@gius80 gius80 requested a review from a team January 30, 2026 17:19
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2026

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • agents-manager
  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/DOMENG-282 on your sandbox.

paulopmt1
paulopmt1 approved these changes Feb 1, 2026
View reviewed changes
Copy link
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working as expected, @gius80. Thanks for the improvement!
I added a unit test with Claude to ensure this is the behavior we want.

Given that we already have a notice, we don't need to implement it.

Before After
image image
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulopmt1 paulopmt1 paulopmt1 approved these changes

Assignees

@gius80 gius80

Labels

[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gius80 @matticbot @paulopmt1