Skip to content

Conversation

@arthur791004
Copy link
Contributor

Part of DOTMSD-1068

Proposed Changes

  • Update the EmptyState when there are no values return from the search.
  • TODO: Confirm the actions
image

Why are these changes being made?

  • Improve the experience of the empty state

Testing Instructions

  • Go to /sites
  • Search any keyword until there is no result
  • Ensure the empty search state is correct

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Jan 30, 2026
@arthur791004 arthur791004 marked this pull request as ready for review January 30, 2026 11:16
@arthur791004 arthur791004 requested a review from a team as a code owner January 30, 2026 11:16
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 30, 2026
empty={ emptyState }
empty={
<EmptySitesState
title={ __( 'No sites match your search' ) }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description "Try again, or start a new site with the options below." seems a bit redundant since the user can see the options. Consider simplifying to just "Try a different search, or start a new site with the options below." to make it clearer what action they should take.

@arthur791004 arthur791004 force-pushed the feat/sites-empty-search-state branch from d7a0be7 to 8d6a548 Compare January 30, 2026 11:19
@matticbot
Copy link
Contributor

matticbot commented Jan 30, 2026

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • help-center
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug feat/sites-empty-search-state on your sandbox.

@arthur791004 arthur791004 changed the title Sites: Update the empty state of the search result Sites: Update the empty state for search results Jan 30, 2026
@arthur791004
Copy link
Contributor Author

Another approach - #108439

@arthur791004
Copy link
Contributor Author

Closing it in favor of #108439.

@arthur791004 arthur791004 deleted the feat/sites-empty-search-state branch February 2, 2026 08:16
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants