Skip to content

Do not generated Swift files with no code #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2025
Merged

Do not generated Swift files with no code #988

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion native/swift/Tools/Sources/GenerateCancellable/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ struct GenerateCancellable: ParsableCommand {

let sourceCode = try String(contentsOf: inputURL, encoding: .utf8)
let extensionsCode = try generateExtensions(sourceCode: sourceCode, logger: logger)
guard !extensionsCode.isEmpty else {
return
}

try extensionsCode.write(to: outputURL, atomically: true, encoding: .utf8)

Expand Down Expand Up @@ -216,13 +219,18 @@ class ExtensionGenerator {
)
)

let content = sourceFile.description.trimmingCharacters(in: .whitespacesAndNewlines)
guard !content.isEmpty else {
return ""
}

return """
// Do not modify. This file is automatically generated.
// swiftlint:disable all

import Foundation

\(sourceFile.description)
\(content)
"""
}

Expand Down