Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Mastodon Apps: Improve Reply Fetching #1118

Merged
merged 12 commits into from
Jan 8, 2025
Merged

Enable Mastodon Apps: Improve Reply Fetching #1118

merged 12 commits into from
Jan 8, 2025

Conversation

akirk
Copy link
Member

@akirk akirk commented Dec 31, 2024

Fixes akirk/friends#424

Before the patch, comments won't be retrieved if the comment was made on the same instance because it provides the status, not just the URL

Proposed changes:

  • Better handling of provided replies by Mastodon

Testing instructions:

  • In the Friends plugin, try to view comments for a post

@github-actions github-actions bot added the [Focus] Compatibility Ensuring the plugin plays well with other plugins label Dec 31, 2024
includes/constants.php Outdated Show resolved Hide resolved
obenland
obenland previously approved these changes Jan 8, 2025
@akirk
Copy link
Member Author

akirk commented Jan 8, 2025

Thanks, @obenland. Please approve again, as I had to fix changelog conflicts.

@akirk akirk merged commit 134dddb into trunk Jan 8, 2025
24 checks passed
@akirk akirk deleted the fix-ema-replies branch January 8, 2025 16:41
obenland added a commit that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Compatibility Ensuring the plugin plays well with other plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fediverse Comments Not Appearing
2 participants