Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Support comment management in Calypso #1104

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

obenland
Copy link
Member

Fixes peLCyI-uB-p2#comment-492

Proposed changes:

  • Adds callbacks to expose custom comment types to the comment API endpoints that power the Calypso comment screen.

Testing instructions:

image

@obenland obenland requested review from jeherve, mikestottuk and a team December 19, 2024 21:34
@obenland obenland self-assigned this Dec 19, 2024
@github-actions github-actions bot added the [Focus] Compatibility Ensuring the plugin plays well with other plugins label Dec 19, 2024
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work in my tests on a self-hosted site ; I must be missing something in setting up my site for that review:

image image

@obenland
Copy link
Member Author

@jeherve Is the comment count correct and the comments don't show up? Or does none of it work?

pfefferle
pfefferle previously approved these changes Dec 23, 2024
pfefferle
pfefferle previously approved these changes Dec 23, 2024
@jeherve
Copy link
Member

jeherve commented Jan 6, 2025

Is the comment count correct and the comments don't show up? Or does none of it work?

The comment count is off by one for some reason, and the reactions are not displayed at all, only the comments:

Calypso

image

WP-Admin

Screenshot 2025-01-06 at 14 47 56

@obenland
Copy link
Member Author

obenland commented Jan 6, 2025

@jeherve Are there other comment types from other plugins by any chance?

To display the comments it requires the jetpack_json_api_comment_types filter that comes with Jetpack 14.2.

@jeherve
Copy link
Member

jeherve commented Jan 7, 2025

To display the comments it requires the jetpack_json_api_comment_types filter that comes with Jetpack 14.2.

🤦! This is what was missing on my site, and as an idiot, I thought that had already shipped! My bad. It works well now.

jeherve
jeherve previously approved these changes Jan 7, 2025
@obenland obenland dismissed stale reviews from jeherve and pfefferle via a8a9f01 January 7, 2025 17:20
@obenland obenland merged commit 3bd67d7 into trunk Jan 7, 2025
24 checks passed
@obenland obenland deleted the add/calypso-comment-management branch January 7, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reactions [Focus] Compatibility Ensuring the plugin plays well with other plugins [Pri] Normal [Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants