Don't load shipping settings if WC shipping or tax-only is enabled #2897
+22
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
Author
|
Also, the GitHub checks always fail on my pull requests. It doesn't seem like this repo is configured correctly to allow drop-in pull requests like this. |
Collaborator
|
Thank you, @PKMN-World ! It seems there’s another scenarios for the only_tax mode that I wasn’t aware of. To address this, I’ve made some changes to let |
3 tasks
Collaborator
|
@PKMN-World thank you for your submission! The QIT tests are failing because the branch is remote. I've pushed the changes to a local branch and created a PR so that the QIT tests will pass here: #2898. We will continue our review there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on from #2883
#2879 did not fix the issue.