Skip to content

Conversation

@bartech
Copy link
Collaborator

@bartech bartech commented Nov 4, 2025

Description

Related issue(s)

Closes https://linear.app/a8c/issue/WOOSHIP-932/automatic-tax-rate-is-returning-the-wrong-rate-for-california-zip
Closes https://linear.app/a8c/issue/WOOSHIP-1646/automated-taxes-calculating-with-stores-base-address-for-ohio
Closes https://linear.app/a8c/issue/WOOSHIP-603/automated-taxes-fetching-rate-for-wrong-county-in-ohio
Closes https://linear.app/a8c/issue/WOOSHIP-1709/some-zipcodes-adds-the-incorrect-tax-total
Closes https://linear.app/a8c/issue/WOOSHIP-963/tax-rounding-product-level-order-level-values-in-api-response-do-not
Closes https://linear.app/a8c/issue/WOOSHIP-1712/tax-rounding-behaviour-after-32
Closes https://linear.app/a8c/issue/WOOSHIP-809/tax-calculation-doesnt-work-as-expected-on-the-cart-page-for-european

Steps to reproduce & screenshots/GIFs

Follow instructions in corresponding issue.

Used addresses

OH
Store:
4376 Edgarton Dr, Grove City, OH 43123

Checkout:
4376 Edgarton Dr, Grove City, OH 43123 should be 8% and falls in Franklin County.
223 W Water Street, Sandusky, OH 44870 should be 6.75% and falls in Erie County
953 Eden Park Dr, Cincinnati, OH 45202 should be 7.8% and falls in Hamilton County
7827 Redsky Dr, Cincinnati, OH 45249

CA
Store:
66 Highway 1, Carmel, CA 93923-9725
Checkout:
120 Highlands Drive, Carmel, CA 93923

NY
Store:
300 Pulteney St, Geneva, NY 14456
Checkout:
7921 Hickory Bottom Rd, Naples, NY 14512

AL
Store and Checkout
6415 Atlanta Hwy, Montgomery, AL 36117

California

ca-addr1 ca-addr2 CA-woo

Ohio

oh-addr1 oh-addr1-woo oh-addr2 oh-addr2-woo oh-addr3 oh-addr3-woo oh-addr4 oh-addr4-woo oh-addr5 oh-addr5-woo

Tax Rounding

Item-level
tax-rounding-item-level
Order-level
tax-rounding-order-level

Case 2 Item-level
tax-rounding-case2-item-level
Case 2 Order-level (when adding each tax item you still get 1 cent discrepancy but order total is good)
tax-rounding-case2-order-level
Case 2 Order-level summary
tax-rounding-case2-order-level-summary

Checklist

  • unit tests
  • changelog.txt entry added
  • readme.txt entry added

@bartech bartech requested review from dustinparker and iyut November 4, 2025 12:26
@bartech bartech self-assigned this Nov 4, 2025
@bartech
Copy link
Collaborator Author

bartech commented Nov 4, 2025

I'm looking into why PHPUnit tests fails for 10.3

Copy link
Collaborator

@dustinparker dustinparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes all of the tax issues mentioned. LGTM!

@bartech bartech merged commit ec48987 into trunk Nov 10, 2025
9 checks passed
@bartech bartech deleted the fix/tax-calculation branch November 10, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants