fix: hide font family option from newsletter#2099
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the newsletter (email) block editor settings to remove the block-level font family control, since fonts registered in WordPress (including via Appearance > Fonts in WP 7.0) can’t be reliably rendered in email clients.
Changes:
- Clears
__experimentalFeatures.typography.fontFamiliesfor newsletter/email editor contexts to hide the font family picker.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks!! |
|
Hey @laurelfulford, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
All Submissions:
Changes proposed in this Pull Request:
WordPress 7.0 introduces an Appearance > Fonts page. While this is somewhat redundant to the font options in the Newspack theme, it has a couple nice benefits:
There's some risks but on the whole it seems like a net positive... one issue is that the font family absolutely will not work in the Newsletter, so this PR removes it. It also renames an editor function to capture that it's now doing more than changing the layout width.
Closes NEWS-1625
How to test the changes in this Pull Request:
...menu next to the Typography header in the sidebar, and confirm one of the options you can add to the panel is 'Font':Other information: