Use continue instead of return when bulk tracking pixel processing#1961
Open
claudiulodro wants to merge 2 commits intotrunkfrom
Open
Use continue instead of return when bulk tracking pixel processing#1961claudiulodro wants to merge 2 commits intotrunkfrom
claudiulodro wants to merge 2 commits intotrunkfrom
Conversation
leogermani
reviewed
Nov 17, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #1961 +/- ##
=========================================
Coverage 24.80% 24.80%
Complexity 2926 2926
=========================================
Files 50 50
Lines 10355 10355
=========================================
Hits 2569 2569
Misses 7786 7786 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkoo
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
Currently the function that records log views uses a
returnif it encounters an invalid newsletter tracking ID. When that happens, all of the other events after it in the list get thrown away and are not tracked. Usingbreakis better IMO, so any valid events after the invalid one get processed.How to test the changes in this Pull Request:
Not sure, but I encountered it in the wild. Something like this:
wp shellandNewspack_Newsletters\Tracking\Pixel::process_logs()Other information: