Skip to content

fix(activecampaign): disable link tracking for test sends #1345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
miguelpeixe wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −5
Draft

fix(activecampaign): disable link tracking for test sends #1345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions includes/service-providers/active_campaign/class-newspack-newsletters-active-campaign.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,8 +656,11 @@ public function test( $post_id, $emails ) {
return $sync_result;
}
/** Create disposable campaign for sending a test. */
$campaign_name = sprintf( 'Test for %s', $this->get_campaign_name( $post ) );
$campaign = $this->create_campaign( get_post( $post_id ), $campaign_name );
$campaign_name = sprintf( 'Test for %s', $this->get_campaign_name( $post ) );
$additional_campaign_data = [
'tracklinks' => 'none', // Disable link tracking for test sends.
];
$campaign = $this->create_campaign( get_post( $post_id ), $campaign_name, $additional_campaign_data );
if ( is_wp_error( $campaign ) ) {
return $campaign;
}
Expand Down Expand Up @@ -796,12 +799,13 @@ public function sync( $post ) {
/**
* Create a campaign for the given post.
*
* @param WP_Post $post Post to create campaign for.
* @param string $campaign_name Optional custom title for this campaign.
* @param WP_Post $post Post to create campaign for.
* @param string $campaign_name Optional custom title for this campaign.
* @param array $additional_campaign_data Optional additional campaign data to send to the API.
*
* @return array|WP_Error Campaign data or error.
*/
private function create_campaign( $post, $campaign_name = '' ) {
private function create_campaign( $post, $campaign_name = '', $additional_campaign_data = [] ) {
$sync_result = $this->sync( $post );
if ( is_wp_error( $sync_result ) ) {
return $sync_result;
Expand All @@ -825,6 +829,7 @@ private function create_campaign( $post, $campaign_name = '' ) {
if ( defined( 'NEWSPACK_NEWSLETTERS_AC_DISABLE_LINK_TRACKING' ) && NEWSPACK_NEWSLETTERS_AC_DISABLE_LINK_TRACKING ) {
$campaign_data['tracklinks'] = 'none';
}
$campaign_data = wp_parse_args( $additional_campaign_data, $campaign_data );
return $this->api_v1_request( 'campaign_create', 'POST', [ 'body' => $campaign_data ] );
}

Expand Down