CRM: Remove experimental automations module - #48422
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 6 files. Only the first 5 are listed here.
Full summary · PHP report · JS report If appropriate, add one of these labels to override the failing coverage check:
Covered by non-unit tests
|
6542e66 to
9a5ee40
Compare
anomiex
left a comment
There was a problem hiding this comment.
I see a few more deps that seem like they can go away.
As for the PR itself... Seems like more of a product decision. 🤷
| @@ -47,12 +25,7 @@ | |||
| "@babel/preset-env": "7.29.2", | |||
| "@babel/runtime": "7.29.2", | |||
There was a problem hiding this comment.
Looks like nothing needs these babel packages anymore.
| "@babel/runtime": "7.29.2", |
| "@wordpress/theme": "0.11.0", | ||
| "chart.js": "4.5.0", | ||
| "copy-webpack-plugin": "14.0.0", | ||
| "css-loader": "6.11.0", |
There was a problem hiding this comment.
css-loader too.
| "css-loader": "6.11.0", |
Proposed changes
This removes an experimental automations module that was never launched, along with its tests and config.
I left a few files related to the project in the
srcfolder that are also not used (behind a feature flag) but have potential (WP REST support, the event manager, and object factories).The
package.jsonwas down to one direct dependency (@wordpress/theme), and that just pulls in a CSS file that is imported by SCSS, so I moved that to be a dev dependency.Related product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions