Connection: Add hooks for external storage provider registration by bindlegirl · Pull Request #48022 · Automattic/jetpack

bindlegirl · 2026-04-09T10:52:41Z

Proposed changes

Add jetpack_external_storage_init action that fires before the first external storage read in External_Storage::get_value(). This gives mu-plugins (like CIAB/Garden) a guaranteed-safe point to register their storage provider via add_action() — no Jetpack classes need to exist at hook-registration time.
Add jetpack_external_storage_provider_registered action that fires after External_Storage::register_provider() is called. Manager::add_connection_status_invalidation_hooks() listens for this and resets the memoized is_connected() result, so a provider registered "too late" still gets picked up on the next check.

Why

On CIAB/Garden sites, connection data comes from external storage (Atomic Persistent Data), not the database. The storage provider is registered from a mu-plugin that loads before Jetpack. However, there was no guaranteed moment tween "Jetpack classes are available" and "Jetpack's first is_connected() call." A recent early call to is_connected() during Jetpack's load (newsletter module) caused the result to be memoized as false before the provider was registered, breaking Big Sky's assembler on garden sites.

These two hooks solve the problem from both directions:

The init hook prevents the stale result by letting providers register at exactly the right time (before the first read)
The invalidation hook is a safety net — if registration happens after a read, the cached status is cleared

Both are backward compatible. Existing consumers (wpcomsh/Atomic) register at include time before any reads; the new actions fire harmlessly with no effect.

Related product discussion/links

CIAB external storage timing issue with is_connected() memoization

Does this pull request change what data or activity we track or use?

No.

Testing instructions

Run the connection package PHP tests: jetpack test php packes/connection
All 630 tests should pass, including 4 new tests:
- test_init_action_fires_on_first_get_value — verifies the init action fires exactly once
- test_init_action_allows_late_provider_registration — verifies a provider registered during the init action serves the triggering read
- test_provider_registered_action_fires — verifies the registered action fires with the correct provider instance
- test_registering_provider_invalidates_stale_is_connected — verifies registering a provider after is_connected() returned false clears the cached result

github-actions · 2026-04-09T10:53:39Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/external-storage-init-hook branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/external-storage-init-hook

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/external-storage-init-hook

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-04-09T10:53:45Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2026-04-09T11:07:55Z

Code Coverage Summary

Coverage changed in 2 files.

File	Coverage	Δ%	Δ Uncovered
projects/packages/connection/src/class-manager.php	608/1015 (59.90%)	-0.06%	1 ❤️‍🩹
projects/packages/connection/src/class-external-storage.php	39/74 (52.70%)	2.70%	0 💚

Full summary · PHP report · JS report

Copilot

Pull request overview

Adds two WordPress actions around external storage provider registration/first-read to make provider registration timing reliable, and ensures Jetpack connection status caching is invalidated when a provider is registered after an initial is_connected() evaluation.

Changes:

Fire jetpack_external_storage_init once, before the first External_Storage::get_value() read, to allow “late” provider registration.
Fire jetpack_external_storage_provider_registered after External_Storage::register_provider() and invalidate memoized connection status in Manager.
Add/extend integration and unit tests covering the new hooks and cache invalidation behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
projects/packages/connection/src/class-external-storage.php	Adds one-time init hook before first read; adds provider-registered hook after registration.
projects/packages/connection/src/class-manager.php	Resets memoized `is_connected()` when an external storage provider is registered.
projects/packages/connection/tests/php/External_Storage_Test.php	Adds tests for init/registered hooks; updates teardown to reset new static state.
projects/packages/connection/tests/php/ManagerIntegrationTest.php	Adds integration test verifying stale `is_connected()` cache is invalidated after provider registration.
projects/packages/connection/changelog/add-external-storage-provider-hooks	Documents the newly added hooks in the connection package changelog.

projects/packages/connection/tests/php/External_Storage_Test.php

projects/packages/connection/tests/php/ManagerIntegrationTest.php

fgiannar

Nice work here, Ana!

I only have a small recommendation: I believe that the cleanup logic in the unit tests you added should happen in tearDown or at least before the assertions.

Plus in test_registering_provider_invalidates_stale_is_connected shouldn't we also reset init_fired same way we do with provider?

- Move action hook cleanup (remove_all_filters) into tearDown() in External_Storage_Test so cleanup is guaranteed even if assertions fail. - Wrap assertions in try/finally in ManagerIntegrationTest to guarantee provider and init_fired cleanup. - Reset init_fired in ManagerIntegrationTest cleanup (per fgiannar). Made-with: Cursor

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

projects/packages/connection/src/class-manager.php

reset_connection_status() takes no parameters; explicitly pass 0 accepted_args so WordPress does not forward the provider argument. Made-with: Cursor

Add hook

a70df80

bindlegirl requested a review from a team as a code owner April 9, 2026 10:52

bindlegirl added the [Status] Needs Review This PR is ready for review. label Apr 9, 2026

bindlegirl self-assigned this Apr 9, 2026

bindlegirl requested a review from WPprodigy April 9, 2026 10:53

github-actions bot added [Package] Connection [Tests] Includes Tests labels Apr 9, 2026

bindlegirl requested a review from Copilot April 9, 2026 11:12

Copilot started reviewing on behalf of bindlegirl April 9, 2026 11:13 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

fgiannar reviewed Apr 9, 2026

View reviewed changes

bindlegirl requested a review from Copilot April 9, 2026 12:42

Copilot started reviewing on behalf of bindlegirl April 9, 2026 12:43 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

projects/packages/connection/src/class-manager.php Outdated Show resolved Hide resolved

Pass accepted_args=0 for provider_registered invalidation hook

8b6244e

reset_connection_status() takes no parameters; explicitly pass 0 accepted_args so WordPress does not forward the provider argument. Made-with: Cursor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Connection: Add hooks for external storage provider registration#48022

Connection: Add hooks for external storage provider registration#48022
bindlegirl wants to merge 3 commits intotrunkfrom
add/external-storage-init-hook

bindlegirl commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

jp-launch-control bot commented Apr 9, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgiannar left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

bindlegirl commented Apr 9, 2026

Proposed changes

Why

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Uh oh!

github-actions bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 9, 2026

Uh oh!

jp-launch-control bot commented Apr 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fgiannar left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 9, 2026 •

edited

Loading

jp-launch-control bot commented Apr 9, 2026 •

edited

Loading