Skip to content

Social: Fix admin page images not loading on Simple #43636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

gmjuhasz
Copy link
Contributor

@gmjuhasz gmjuhasz commented May 27, 2025

Fixes SOCIAL-48

Proposed changes:

  • Added a new file for setting the publicPath
  • Extended the script-data with the URL

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

SOCIAL-48

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

To test the issue:

  • Rsync trunk to your sandbox, and go to your sandboxed simple site. Add &concat_js=yes to the URL.
  • On the Social Admin page in the Jetpack submenu, open the SIG settings modal, or the example images in the connection management modal, they won't load.
  • Now switch to this branch and rsync it.
  • Refresh the page, the images should load up fine, the URL should be <SITE_URL>/wp-content/mu-plugins/jetpack-plugin/sun/jetpack_vendor/automattic/jetpack-publicize/build/images/...

@gmjuhasz gmjuhasz requested a review from a team May 27, 2025 09:00
@gmjuhasz gmjuhasz self-assigned this May 27, 2025
@gmjuhasz gmjuhasz added the [Status] Needs Review This PR is ready for review. label May 27, 2025
@github-actions github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin RNA labels May 27, 2025
Copy link
Contributor

github-actions bot commented May 27, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: June 3, 2025
    • Code freeze: June 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels May 27, 2025
Copy link
Contributor

github-actions bot commented May 27, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the fix/social/admin-page-assets-public-path branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack fix/social/admin-page-assets-public-path

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

jp-launch-control bot commented May 27, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/publicize/src/class-publicize-script-data.php 0/119 (0.00%) 0.00% 1 ❤️‍🩹

1 file is newly checked for coverage.

File Coverage
projects/js-packages/publicize-components/src/set-webpack-public-path.js 0/2 (0.00%) 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@gmjuhasz gmjuhasz added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label May 27, 2025
@gmjuhasz gmjuhasz changed the title Social: Fix admin page images not loading Social: Fix admin page images not loading on Simple May 28, 2025
@gmjuhasz
Copy link
Contributor Author

Based on some Linear confusion Manzoor also created a fix for it, so I'll close this and we can move forward with #43655

@gmjuhasz gmjuhasz closed this May 28, 2025
@github-actions github-actions bot removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Publicize Now Jetpack Social, auto-sharing I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [JS Package] Publicize Components [Package] Publicize [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] Social Issues about the Jetpack Social plugin RNA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant