Connection: protected owner errors manual fix #43593

bindlegirl · 2025-05-23T11:20:11Z

Related to: VULCAN-86
P2: pghT6q-3V-p2

Proposed changes:

Adding filter to Error_Handler class so wpcomsh can plug in with Protected owner errors.
Adapted js components to handle protected owner errors and display a different button that redirects users to account creation.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Testing instructions in Connection: protected owner class #43601

github-actions · 2025-05-23T11:21:00Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the add/protected_owner_error_manual branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack add/protected_owner_error_manual

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/protected_owner_error_manual

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-05-23T11:21:12Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: June 3, 2025
- Code freeze: June 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-05-23T11:33:05Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/jetpack/_inc/client/components/jetpack-notices/jetpack-connection-errors.jsx	2/17 (11.76%)	-1.57%	2 ❤️‍🩹
projects/packages/my-jetpack/_inc/hooks/use-notification-watcher/use-connection-errors-notice.tsx	25/25 (100.00%)	100.00%	-18 💚
projects/packages/connection/src/class-error-handler.php	186/244 (76.23%)	11.79%	-22 💚

Full summary · PHP report · JS report

fgiannar · 2025-05-29T08:28:20Z

projects/js-packages/connection/hooks/use-connection-error-notice/index.jsx

@@ -11,7 +11,9 @@ import useRestoreConnection from '../../hooks/use-restore-connection/index.jsx';
 */
 export default function useConnectionErrorNotice() {
 	const { connectionErrors } = useConnection( {} );
+


Do we need these changes here?

fgiannar · 2025-05-29T08:35:44Z

projects/packages/connection/src/class-error-handler.php

+			'invalid_connection_owner',
+		);
+
+		// Automatically include any error codes that aren't in the default list


As we discussed, I think it's safer to hardcode the error code coming from wpcomsh here and also add it in the $known_errors list.
The concept of this class is that we only allow verified connection errors to show up.
An exception is the invalid_connection_owner which is not verified but is set by the same package so it's safe.
The filter we introduced is enough to allow wpcomsh to handle it's own connection errors without storing them but I don't see any other plugin handling connection errors.

Changed in latest comit

fgiannar

This is what I see when I create the missing user manually:

I was testing with a secondary non-connected admin. I was under the impression that we only display errors for the current user when the error has user_id set. Isn't this the case?

github-actions bot added [Package] Connection [Package] My Jetpack [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Status] In Progress Admin Page React-powered dashboard under the Jetpack menu labels May 23, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 23, 2025

github-actions bot added [JS Package] Connection RNA [Tests] Includes Tests labels May 23, 2025

bindlegirl mentioned this pull request May 26, 2025

Connection: protected owner class #43601

Open

3 tasks

bindlegirl added 5 commits May 26, 2025 13:08

Added protected owner error support

c68b9c9

Changelogs

fa09a8b

Fix for my jetpack

6acff66

changelog

db18e4d

Add tests

108bade

bindlegirl force-pushed the add/protected_owner_error_manual branch from 46b524f to 108bade Compare May 26, 2025 11:09

bindlegirl self-assigned this May 26, 2025

bindlegirl requested a review from fgiannar May 26, 2025 11:10

bindlegirl marked this pull request as ready for review May 26, 2025 11:45

bindlegirl added [Type] Feature Development of a new feature [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels May 26, 2025

bindlegirl added 4 commits May 28, 2025 14:36

Everything goes to error_handler

8abf2ac

Bug hunting and tests

593925c

Revert change in initial state file

7d2730d

Remove redundant js component

4cb45b4

fgiannar requested changes May 29, 2025

View reviewed changes

bindlegirl added 3 commits May 29, 2025 11:21

Hardcoding protected owner error to verified error array

63bbacd

Unset invalid_connection_owner on WoA

30f930a

Remove WoA handling so we can move it to wpcomsh

764b894

fgiannar requested changes May 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Connection: protected owner errors manual fix #43593

Connection: protected owner errors manual fix #43593

Uh oh!

bindlegirl commented May 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented May 23, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented May 23, 2025 •

edited

Loading

Uh oh!

fgiannar May 29, 2025

Uh oh!

fgiannar May 29, 2025

Uh oh!

bindlegirl May 29, 2025

Uh oh!

fgiannar left a comment

Uh oh!

Uh oh!

Connection: protected owner errors manual fix #43593

Are you sure you want to change the base?

Connection: protected owner errors manual fix #43593

Uh oh!

Conversation

bindlegirl commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

fgiannar May 29, 2025

Choose a reason for hiding this comment

Uh oh!

fgiannar May 29, 2025

Choose a reason for hiding this comment

Uh oh!

bindlegirl May 29, 2025

Choose a reason for hiding this comment

Uh oh!

fgiannar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bindlegirl commented May 23, 2025 •

edited

Loading

github-actions bot commented May 23, 2025 •

edited

Loading

github-actions bot commented May 23, 2025 •

edited

Loading

jp-launch-control bot commented May 23, 2025 •

edited

Loading