Skip to content

Podcast Player: handle dual-behaviour of render_callback fn #15515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
retrofox wants to merge 4 commits into from
Closed

Podcast Player: handle dual-behaviour of render_callback fn #15515

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca434a5
podcast-player: handle dual-behaviour of render
retrofox Apr 21, 2020
3fc7cf6
Update extensions/blocks/podcast-player/podcast-player.php
retrofox Apr 22, 2020
cf9902c
podcast-player: update passing $attributes var
retrofox Apr 22, 2020
debd495
podcast-player: improve jsdoc
retrofox Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion extensions/blocks/podcast-player/podcast-player.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ function register_block() {
/**
* Podcast Player block registration/dependency declaration.
*
* @param array $attributes Array containing the Podcast Player block attributes.
* @param array|WP_Block $attributes Podcast Player block attributes / WP_Block instance.
* @return string
*/
function render_block( $attributes ) {
Expand All @@ -79,6 +79,18 @@ function render_block( $attributes ) {
return '<p>' . esc_html( $player_data->get_error_message() ) . '</p>';
}

/*
* Get the block attributes checking if `$attributes`
* is an array and it has defined a property.
*
* It handles the dual-behavior of argument
* of the callback_render() function, which
* was recently introduced by this Pull Request:
* https://github.com/WordPress/gutenberg/pull/21467
*/
if ( ! empty( $attributes->attributes ) ) {
$attributes = $attributes->attributes;
}
return render_player( $player_data, $attributes );
}

Expand Down