Skip to content

[jobs] shortcode: add author attribute to filter listings by user ID #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masteradhoc wants to merge 16 commits into
base: trunk
Choose a base branch
from
+172 −1
Open

[jobs] shortcode: add author attribute to filter listings by user ID #2935

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
62c0803
add author to ajax
masteradhoc Mar 29, 2026
ea7d6e1
add author to functions
masteradhoc Mar 29, 2026
e71145e
add author feature to shortcode
masteradhoc Mar 29, 2026
ed1e3b6
add author to ajax
masteradhoc Mar 29, 2026
748597e
add condition to rss feed
masteradhoc Apr 8, 2026
d6784d5
add author to rss feed
masteradhoc Apr 8, 2026
d0c636d
remove bypass cache
masteradhoc Apr 18, 2026
d50a788
Update wp-job-manager-functions.php
masteradhoc Apr 21, 2026
336c898
add tests
masteradhoc May 3, 2026
6159ea7
Merge branch 'Automattic:trunk' into 1892-user-filter
masteradhoc May 7, 2026
d4b32ce
add author to getlistings
masteradhoc May 7, 2026
97d8e59
empty result for wrong author ids
masteradhoc May 7, 2026
9a2fe36
add tests
masteradhoc May 7, 2026
e469f51
fix: author filter fails-closed, reject negative/invalid IDs, add PHP…
masteradhoc May 7, 2026
d7d1bc3
fix tests
masteradhoc May 7, 2026
1872f2e
fix array/string
masteradhoc May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions assets/js/ajax-filters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ jQuery( document ).ready( function( $ ) {
var remote_position = $target.data( 'remote_position' );
var job_types = $target.data( 'job_types' );
var post_status = $target.data( 'post_status' );
var author = $target.data( 'author' );
var index = $( 'div.job_listings' ).index( this );
var categories, keywords, location;

Expand Down Expand Up @@ -387,6 +388,7 @@ jQuery( document ).ready( function( $ ) {
featured: featured,
filled: filled,
remote_position: remote_position,
author: author,
show_pagination: $target.data( 'show_pagination' ),
form_data: $form.serialize(),
};
Expand Down Expand Up @@ -416,6 +418,7 @@ jQuery( document ).ready( function( $ ) {
featured: featured,
filled: filled,
remote_position: remote_position,
author: author,
show_pagination: $target.data( 'show_pagination' ),
};
}
Expand Down
2 changes: 2 additions & 0 deletions includes/class-wp-job-manager-ajax.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ public function get_listings() {
$remote_position = isset( $_REQUEST['remote_position'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['remote_position'] ) ) : null;
$show_pagination = isset( $_REQUEST['show_pagination'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['show_pagination'] ) ) : null;
$featured_first = isset( $_REQUEST['featured_first'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['featured_first'] ) ) : null;
$author = isset( $_REQUEST['author'] ) ? sanitize_text_field( wp_unslash( $_REQUEST['author'] ) ) : '';
// phpcs:enable WordPress.Security.NonceVerification.Recommended

if ( is_array( $search_categories ) ) {
Expand All @@ -161,6 +162,7 @@ public function get_listings() {
'orderby' => $orderby,
'order' => $order,
'featured_first' => $featured_first,
'author' => $author,
'offset' => ( $page - 1 ) * $per_page,
'posts_per_page' => max( 1, $per_page ), // phpcs:ignore WordPress.WP.PostsPerPage.posts_per_page_posts_per_page -- Known slow query.
];
Expand Down
11 changes: 11 additions & 0 deletions includes/class-wp-job-manager-post-types.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,6 +727,13 @@ public function job_feed() {
$input_job_categories = false;
}

if ( isset( $_GET['author'] ) ) {
$sanitized_author = sanitize_text_field( wp_unslash( $_GET['author'] ) );
$input_author = empty( $sanitized_author ) ? false : array_filter( array_map( 'absint', explode( ',', $sanitized_author ) ) );
} else {
$input_author = false;
}

$job_manager_keyword = isset( $_GET['search_keywords'] ) ? sanitize_text_field( wp_unslash( $_GET['search_keywords'] ) ) : '';
// phpcs:enable WordPress.Security.NonceVerification.Recommended

Expand Down Expand Up @@ -790,6 +797,10 @@ public function job_feed() {
];
}

if ( ! empty( $input_author ) ) {
$query_args['author__in'] = $input_author;
}

if ( ! empty( $job_manager_keyword ) ) {
$query_args['s'] = $job_manager_keyword;
add_filter( 'posts_search', 'get_job_listings_keyword_search', 10, 2 );
Expand Down
6 changes: 6 additions & 0 deletions includes/class-wp-job-manager-shortcodes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ public function output_jobs( $atts ) {
'filled' => null, // True to show only filled, false to hide filled, leave null to show both/use the settings.
'remote_position' => null, // True to show only remote, false to hide remote, leave null to show both.
'featured_first' => false, // True to show featured first, false to show in default order.
'author' => 0, // Limit listings to a specific author by user ID. 0 shows all.

// Default values for filters.
'location' => '',
Expand All @@ -237,6 +238,7 @@ public function output_jobs( $atts ) {
$atts['show_more'] = $this->string_to_bool( $atts['show_more'] );
$atts['show_pagination'] = $this->string_to_bool( $atts['show_pagination'] );
$atts['featured_first'] = $this->string_to_bool( $atts['featured_first'] );
$atts['author'] = sanitize_text_field( $atts['author'] );

if ( ! is_null( $atts['featured'] ) ) {
$atts['featured'] = ( is_bool( $atts['featured'] ) && $atts['featured'] ) || in_array( $atts['featured'], [ 1, '1', 'true', 'yes' ], true );
Expand Down Expand Up @@ -349,6 +351,7 @@ public function output_jobs( $atts ) {
'filled' => $atts['filled'],
'remote_position' => $atts['remote_position'],
'featured_first' => $atts['featured_first'],
'author' => $atts['author'],
]
)
);
Expand Down Expand Up @@ -392,6 +395,9 @@ public function output_jobs( $atts ) {
if ( ! empty( $atts['post_status'] ) ) {
$data_attributes['post_status'] = implode( ',', $atts['post_status'] );
}
if ( ! empty( $atts['author'] ) ) {
$data_attributes['author'] = $atts['author'];
}

$data_attributes['post_id'] = isset( $GLOBALS['post'] ) ? $GLOBALS['post']->ID : 0;

Expand Down
15 changes: 15 additions & 0 deletions wp-job-manager-functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,15 @@ function get_job_listings( $args = [] ) {
];
}

if ( ! empty( $args['author'] ) ) {
$author_ids = is_array( $args['author'] )
? array_filter( array_map( 'absint', $args['author'] ) )
: array_filter( array_map( 'absint', explode( ',', $args['author'] ) ) );
Comment thread
masteradhoc marked this conversation as resolved.
Outdated
if ( ! empty( $author_ids ) ) {
$query_args['author__in'] = $author_ids;
}
}

$job_manager_keyword = sanitize_text_field( $args['search_keywords'] );

if ( ! empty( $job_manager_keyword ) && strlen( $job_manager_keyword ) >= apply_filters( 'job_manager_get_listings_keyword_length_threshold', 2 ) ) {
Expand Down Expand Up @@ -219,6 +228,11 @@ function get_job_listings( $args = [] ) {

$should_cache = 'rand_featured' !== $args['orderby'] && 'rand' !== $args['orderby'];

// Bypass cache when author filter is active to avoid stale results.
Copy link
Copy Markdown
Contributor

@donnchawp donnchawp Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is required? The cache key is derived from $to_hash = wp_json_encode( $query_args ); so having the author field in there will create a new cache key. It shouldn't be stale.

Copy link
Copy Markdown
Contributor Author

@masteradhoc masteradhoc Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had issues while applying the PR that the change didnt show. but when i retest now all seems fine even without this part. so i went ahead and removed it now @donnchawp - thanks!

if ( ! empty( $query_args['author__in'] ) ) {
$should_cache = false;
}

// Cache results.
if ( apply_filters( 'get_job_listings_cache_results', $should_cache ) ) {
$to_hash = wp_json_encode( $query_args );
Expand Down Expand Up @@ -630,6 +644,7 @@ function job_manager_get_filtered_links( $args = [] ) {
'search_location' => $args['search_location'],
'job_categories' => implode( ',', $job_categories ),
'search_keywords' => $args['search_keywords'],
'author' => ! empty( $args['author'] ) ? $args['author'] : '',
]
)
),
Expand Down
Loading