Fix camera parameter translations and simplify code #302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjeziorski
force-pushed
the
fix_cameraAdapter_translation
branch
from
59258e8 to
b60d6ba
Compare
jjeziorski
force-pushed
the
fix_cameraAdapter_translation
branch
from
b60d6ba to
9d55a9c
Compare
Collaborator
|
@jjeziorski have you had a chance to try the change with custom attributes support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the translation of focus distance and simplify the handling of camera lens and aperture parameters. Enhance the retrieval of camera attributes by searching for requested parameters directly.
Value for focus distance was incorrectly assumed in inches, which is not consistent with docs
I'm not sure where logic for computing lens focal and aperture came from, but it was expensive,
units were way off and gave wrong values for depth of field calculations. With proposed changes values are consistent with values exported by
maya-usd.I've also added proposed change to support custom attributes by checking camera plugs.